From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752416AbbCWKkZ (ORCPT ); Mon, 23 Mar 2015 06:40:25 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:48964 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752104AbbCWKkX (ORCPT ); Mon, 23 Mar 2015 06:40:23 -0400 Date: Mon, 23 Mar 2015 13:40:06 +0300 From: Dan Carpenter To: Nicholas Krause Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, aaro.koskinen@iki.fi, pauldaviesc@gmail.com, nitinkuppelur@gmail.com, linux-kernel@vger.kernel.org, br@ahlamon.org Subject: Re: [PATCH 1/2] octeon-usb:Fix coding style issue with space between function name and opening bracket Message-ID: <20150323104006.GZ10964@mwanda> References: <1427069076-26720-1-git-send-email-xerofoify@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1427069076-26720-1-git-send-email-xerofoify@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Mar 22, 2015 at 08:04:35PM -0400, Nicholas Krause wrote: > Fixes the checkpath.pl error where the opening bracket has a unneeded space between > it and the function name for a if statement in the marco,VMX_WAIT_FOR_FIELD32. > > Signed-off-by: Nicholas Krause > --- > drivers/staging/octeon-usb/octeon-hcd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/octeon-usb/octeon-hcd.c b/drivers/staging/octeon-usb/octeon-hcd.c > index 1daeb31..0408a12 100644 > --- a/drivers/staging/octeon-usb/octeon-hcd.c > +++ b/drivers/staging/octeon-usb/octeon-hcd.c > @@ -412,7 +412,7 @@ struct octeon_hcd { > type c; \ > while (1) { \ > c.u32 = __cvmx_usb_read_csr32(usb, address); \ > - if (c.s.field op (value)) { \ > + if (c.s.field op(value)) { \ "op" is not a function here. This is macro and top is an operation like "+" or "*". So checkpatch.pl is wrong. regards, dan carpenter