* [PATCH] Staging: rtl8188eu: remove dead code
@ 2015-03-20 19:41 Matteo Semenzato
2015-03-23 11:54 ` Dan Carpenter
0 siblings, 1 reply; 2+ messages in thread
From: Matteo Semenzato @ 2015-03-20 19:41 UTC (permalink / raw)
To: gregkh, navin.patidar, hejianet, sudipm.mukherjee
Cc: devel, linux-kernel, Matteo Semenzato
From: Matteo Semenzato <mattew8898@gmail.com>
The condition pxmitpriv->hwxmit_entry == 5 is always false because
HWXMIT_ENTRY is always 4.
Signed-off-by: Matteo Semenzato <mattew8898@gmail.com>
---
drivers/staging/rtl8188eu/core/rtw_xmit.c | 17 ++++-------------
1 file changed, 4 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_xmit.c b/drivers/staging/rtl8188eu/core/rtw_xmit.c
index 7a71df1..edc048c 100644
--- a/drivers/staging/rtl8188eu/core/rtw_xmit.c
+++ b/drivers/staging/rtl8188eu/core/rtw_xmit.c
@@ -1638,19 +1638,10 @@ void rtw_alloc_hwxmits(struct adapter *padapter)
hwxmits = pxmitpriv->hwxmits;
- if (pxmitpriv->hwxmit_entry == 5) {
- hwxmits[0] .sta_queue = &pxmitpriv->bm_pending;
- hwxmits[1] .sta_queue = &pxmitpriv->vo_pending;
- hwxmits[2] .sta_queue = &pxmitpriv->vi_pending;
- hwxmits[3] .sta_queue = &pxmitpriv->bk_pending;
- hwxmits[4] .sta_queue = &pxmitpriv->be_pending;
- } else if (pxmitpriv->hwxmit_entry == 4) {
- hwxmits[0] .sta_queue = &pxmitpriv->vo_pending;
- hwxmits[1] .sta_queue = &pxmitpriv->vi_pending;
- hwxmits[2] .sta_queue = &pxmitpriv->be_pending;
- hwxmits[3] .sta_queue = &pxmitpriv->bk_pending;
- } else {
- }
+ hwxmits[0] .sta_queue = &pxmitpriv->vo_pending;
+ hwxmits[1] .sta_queue = &pxmitpriv->vi_pending;
+ hwxmits[2] .sta_queue = &pxmitpriv->be_pending;
+ hwxmits[3] .sta_queue = &pxmitpriv->bk_pending;
}
void rtw_free_hwxmits(struct adapter *padapter)
--
2.3.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Staging: rtl8188eu: remove dead code
2015-03-20 19:41 [PATCH] Staging: rtl8188eu: remove dead code Matteo Semenzato
@ 2015-03-23 11:54 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2015-03-23 11:54 UTC (permalink / raw)
To: Matteo Semenzato
Cc: gregkh, navin.patidar, hejianet, sudipm.mukherjee, devel,
linux-kernel
On Fri, Mar 20, 2015 at 08:41:45PM +0100, Matteo Semenzato wrote:
> From: Matteo Semenzato <mattew8898@gmail.com>
>
> The condition pxmitpriv->hwxmit_entry == 5 is always false because
> HWXMIT_ENTRY is always 4.
>
> Signed-off-by: Matteo Semenzato <mattew8898@gmail.com>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-03-23 11:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-20 19:41 [PATCH] Staging: rtl8188eu: remove dead code Matteo Semenzato
2015-03-23 11:54 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox