From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752505AbbCWL55 (ORCPT ); Mon, 23 Mar 2015 07:57:57 -0400 Received: from 8bytes.org ([81.169.241.247]:33637 "EHLO theia.8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751873AbbCWL54 (ORCPT ); Mon, 23 Mar 2015 07:57:56 -0400 Date: Mon, 23 Mar 2015 12:57:54 +0100 From: Joerg Roedel To: Feng Wu Cc: dwmw2@infradead.org, jiang.liu@linux.intel.com, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [v4 2/8] iommu, x86: Define new irte structure for VT-d Posted-Interrupts Message-ID: <20150323115754.GN4441@8bytes.org> References: <1422864424-19411-1-git-send-email-feng.wu@intel.com> <1422864424-19411-3-git-send-email-feng.wu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1422864424-19411-3-git-send-email-feng.wu@intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Feng, On Mon, Feb 02, 2015 at 04:06:58PM +0800, Feng Wu wrote: > Add a new irte_pi structure for VT-d Posted-Interrupts. > > Signed-off-by: Feng Wu > Reviewed-by: Jiang Liu > Acked-by: David Woodhouse > --- > include/linux/dmar.h | 32 ++++++++++++++++++++++++++++++++ > 1 files changed, 32 insertions(+), 0 deletions(-) > > diff --git a/include/linux/dmar.h b/include/linux/dmar.h > index 8473756..c7f9cda 100644 > --- a/include/linux/dmar.h > +++ b/include/linux/dmar.h > @@ -212,6 +212,38 @@ struct irte { > }; > }; > > +struct irte_pi { I think it is better to put this as a union into struct irte. It saves memory and unnecessary casting in later patches. Joerg