From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753160AbbCWMsx (ORCPT ); Mon, 23 Mar 2015 08:48:53 -0400 Received: from mail-pa0-f44.google.com ([209.85.220.44]:35546 "EHLO mail-pa0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752310AbbCWMsL (ORCPT ); Mon, 23 Mar 2015 08:48:11 -0400 Date: Mon, 23 Mar 2015 18:18:00 +0530 From: Sudip Mukherjee To: Amitoj Kaur Chawla Cc: teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] sm750fb: Fix C99 comment and if-else braces Message-ID: <20150323124800.GA8151@sudip-PC> References: <20150320142455.GA17954@amitoj-Inspiron-3542> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150320142455.GA17954@amitoj-Inspiron-3542> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 20, 2015 at 07:54:56PM +0530, Amitoj Kaur Chawla wrote: > The edits have been made to fix C99 Comment and properly indent > the if-else statements with the braces. i think you are doing multiple types of changes in one patch. better to send it in a series of two, one for the C99 and the other for the if-else. and there are few more places in that file where C99 is used, any reason why you have chosen only one? scripts/checkpatch.pl --strict -f drivers/staging/sm750fb/ddk750_chip.c | grep C99 | wc -l 6 and, your patch is not applying, please refresh your patch against staging-testing. regards sudip >