From: Ingo Molnar <mingo@kernel.org>
To: Denys Vlasenko <dvlasenk@redhat.com>
Cc: tglx@linutronix.de, fweisbec@gmail.com, ast@plumgrid.com,
oleg@redhat.com, luto@amacapital.net, keescook@chromium.org,
hpa@zytor.com, bp@alien8.de, torvalds@linux-foundation.org,
rostedt@goodmis.org, linux-kernel@vger.kernel.org,
wad@chromium.org, linux-tip-commits@vger.kernel.org
Subject: Re: [tip:x86/asm] x86/asm/entry/64: Rename 'old_rsp' to 'rsp_scratch'
Date: Mon, 23 Mar 2015 14:58:33 +0100 [thread overview]
Message-ID: <20150323135833.GC25233@gmail.com> (raw)
In-Reply-To: <55086B1F.6020602@redhat.com>
* Denys Vlasenko <dvlasenk@redhat.com> wrote:
> On 03/17/2015 05:43 PM, tip-bot for Ingo Molnar wrote:
> > Commit-ID: c38e503804b0402c510f82437069f7769fa0cea9
> > Gitweb: http://git.kernel.org/tip/c38e503804b0402c510f82437069f7769fa0cea9
> > Author: Ingo Molnar <mingo@kernel.org>
> > AuthorDate: Tue, 17 Mar 2015 14:42:59 +0100
> > Committer: Ingo Molnar <mingo@kernel.org>
> > CommitDate: Tue, 17 Mar 2015 16:01:42 +0100
> >
> > x86/asm/entry/64: Rename 'old_rsp' to 'rsp_scratch'
> >
> > Make clear that the usage of PER_CPU(old_rsp) is purely temporary,
> > by renaming it to 'rsp_scratch'.
> ...
> > @@ -657,7 +657,7 @@ common_interrupt:
> > ASM_CLAC
> > addq $-0x80,(%rsp) /* Adjust vector to [-256,-1] range */
> > interrupt do_IRQ
> > - /* 0(%rsp): old_rsp */
> > + /* 0(%rsp): rsp_scratch */
> > ret_from_intr:
>
> Here the "old_rsp" word in comment did not refer to old_rsp variable.
>
> Rather, it literally means "old %rsp register value (before we possibly
> switched to per-CPU interrupt stack)".
>
> The stack switch is hidden in "interrupt do_IRQ" macro invocation.
>
> I think here "old_rsp" needs to be replaced by "old rsp" or "old %rsp".
Indeed - and I applied your comment-fix patch.
Thanks,
Ingo
prev parent reply other threads:[~2015-03-23 13:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <tip-c38e503804b0402c510f82437069f7769fa0cea9@git.kernel.org>
2015-03-17 17:49 ` [tip:x86/asm] x86/asm/entry/64: Rename 'old_rsp' to 'rsp_scratch' Andy Lutomirski
2015-03-17 17:57 ` Denys Vlasenko
2015-03-23 13:58 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150323135833.GC25233@gmail.com \
--to=mingo@kernel.org \
--cc=ast@plumgrid.com \
--cc=bp@alien8.de \
--cc=dvlasenk@redhat.com \
--cc=fweisbec@gmail.com \
--cc=hpa@zytor.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=oleg@redhat.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=wad@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox