From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752667AbbCWN6k (ORCPT ); Mon, 23 Mar 2015 09:58:40 -0400 Received: from mail-we0-f174.google.com ([74.125.82.174]:36109 "EHLO mail-we0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752207AbbCWN6i (ORCPT ); Mon, 23 Mar 2015 09:58:38 -0400 Date: Mon, 23 Mar 2015 14:58:33 +0100 From: Ingo Molnar To: Denys Vlasenko Cc: tglx@linutronix.de, fweisbec@gmail.com, ast@plumgrid.com, oleg@redhat.com, luto@amacapital.net, keescook@chromium.org, hpa@zytor.com, bp@alien8.de, torvalds@linux-foundation.org, rostedt@goodmis.org, linux-kernel@vger.kernel.org, wad@chromium.org, linux-tip-commits@vger.kernel.org Subject: Re: [tip:x86/asm] x86/asm/entry/64: Rename 'old_rsp' to 'rsp_scratch' Message-ID: <20150323135833.GC25233@gmail.com> References: <55086B1F.6020602@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55086B1F.6020602@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Denys Vlasenko wrote: > On 03/17/2015 05:43 PM, tip-bot for Ingo Molnar wrote: > > Commit-ID: c38e503804b0402c510f82437069f7769fa0cea9 > > Gitweb: http://git.kernel.org/tip/c38e503804b0402c510f82437069f7769fa0cea9 > > Author: Ingo Molnar > > AuthorDate: Tue, 17 Mar 2015 14:42:59 +0100 > > Committer: Ingo Molnar > > CommitDate: Tue, 17 Mar 2015 16:01:42 +0100 > > > > x86/asm/entry/64: Rename 'old_rsp' to 'rsp_scratch' > > > > Make clear that the usage of PER_CPU(old_rsp) is purely temporary, > > by renaming it to 'rsp_scratch'. > ... > > @@ -657,7 +657,7 @@ common_interrupt: > > ASM_CLAC > > addq $-0x80,(%rsp) /* Adjust vector to [-256,-1] range */ > > interrupt do_IRQ > > - /* 0(%rsp): old_rsp */ > > + /* 0(%rsp): rsp_scratch */ > > ret_from_intr: > > Here the "old_rsp" word in comment did not refer to old_rsp variable. > > Rather, it literally means "old %rsp register value (before we possibly > switched to per-CPU interrupt stack)". > > The stack switch is hidden in "interrupt do_IRQ" macro invocation. > > I think here "old_rsp" needs to be replaced by "old rsp" or "old %rsp". Indeed - and I applied your comment-fix patch. Thanks, Ingo