From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752691AbbCWONJ (ORCPT <rfc822;w@1wt.eu>);
	Mon, 23 Mar 2015 10:13:09 -0400
Received: from mail.kernel.org ([198.145.29.136]:37748 "EHLO mail.kernel.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752608AbbCWONB (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 23 Mar 2015 10:13:01 -0400
Date: Mon, 23 Mar 2015 11:13:00 -0300
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ingo Molnar <mingo@kernel.org>
Cc: linux-kernel@vger.kernel.org, Jiri Olsa <jolsa@kernel.org>,
        Corey Ashford <cjashfor@linux.vnet.ibm.com>,
        David Ahern <david.ahern@oracle.com>,
        Namhyung Kim <namhyung@kernel.org>, Paul Mackerras <paulus@samba.org>,
        Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH 14/31] perf build: Rename PERF-FEATURES into FEATURE-DUMP
Message-ID: <20150323141300.GW16485@kernel.org>
References: <1426784707-19466-1-git-send-email-acme@kernel.org>
 <1426784707-19466-15-git-send-email-acme@kernel.org>
 <20150322101932.GA2255@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150322101932.GA2255@gmail.com>
X-Url: http://acmel.wordpress.com
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Em Sun, Mar 22, 2015 at 11:19:33AM +0100, Ingo Molnar escreveu:
> 
> * Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> 
> > From: Jiri Olsa <jolsa@kernel.org>
> > 
> > Preparing for feature checks separation, moving related stuff under
> > 'FEATURE*' namespace.
> > 
> > Signed-off-by: Jiri Olsa <jolsa@kernel.org>
> > Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com>
> > Cc: David Ahern <david.ahern@oracle.com>
> > Cc: Namhyung Kim <namhyung@kernel.org>
> > Cc: Paul Mackerras <paulus@samba.org>
> > Cc: Peter Zijlstra <peterz@infradead.org>
> > Link: http://lkml.kernel.org/n/tip-v9oo22ra70rrk1dy495a7bjc@git.kernel.org
> > Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> 
> So I think the various capital letter files in $(cwd) are highly 
> suboptimal:
> 
>  FEATURE-DUMP
>  PERF-CFLAGS
>  PERF-VERSION-FILE
> 
> I think we should standardize on something less pushy (no shouting), 
> plus more standardized, more logical, more coherent names, i.e. 
> something like:
> 
>    .build.features.cache
>    .build.cflags
>    .build.version
> 
> ?
> 
> .build.features.* would be reserved to the generic feature detection 
> machinery.
> 
> .build.cflags and .build.version could be used by the perf build - 
> hopefully exported to tools/build/ as well in the future! :-)
> 
> That way the .gitignore could just ignore .build.* and we'd not have 
> to update it much.

Agreed, Jiri?
 
> Btw., another small nit: could we please do a (git-)rename of 
> tools/build/feature/ to tools/build/features/?

> Plural is what is used typically for generic frameworks that deal with 
> a set of items (features in this case) - for example we have 
> tools/tests/, and tools/perf/scripts/, not tools/test/ and 
> tools/perf/script/.

This one is easy enough, will do in my next pull req.

- Arnaldo