Re: [PATCH v2 2/4] mfd: wm5110: Add register patch required for low power sleep

Lee Jones
2015-03-23T14:13:16Z

On Tue, 17 Mar 2015, Charles Keepax wrote:

> Some register settings must be applied before the first time low power
> sleep mode is entered on the wm5110 to ensure optimium performance.
> These settings require SYSCLK to be enabled whilst they are being
> applied. This patch applies the settings using the recently factored out
> boot time SYSCLK functionality.
>
> Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
> ---
> drivers/mfd/arizona-core.c | 29 +++++++++++++++++++++++++++++
> 1 files changed, 29 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c
> index ef1f8aa..8f61ccf 100644
> --- a/drivers/mfd/arizona-core.c
> +++ b/drivers/mfd/arizona-core.c
> @@ -344,6 +344,25 @@ static inline int arizona_apply_hardware_patch(struct arizona *arizona)
> return arizona_exec_with_sysclk(arizona, arizona_hardware_patch_wseq);
> }
>
> +static const struct reg_default wm5110_sleep_patch[] = {
> + { 0x337A, 0xC100 },
> + { 0x337B, 0x0041 },
> + { 0x3300, 0xA210 },
> + { 0x3301, 0x050C },
> +};

Really not keen on all these magic numbers.

Would you be kind enough to define them please?

> +static inline int wm5110_sleep_patch_wseq(struct arizona *arizona)

What is 'wseq'?

I suggest if I'm having to ask that it's not a very good name.

> +{
> + return regmap_multi_reg_write_bypassed(arizona->regmap,
> + wm5110_sleep_patch,
> + ARRAY_SIZE(wm5110_sleep_patch));
> +}
> +
> +static inline int wm5110_apply_sleep_patch(struct arizona *arizona)
> +{
> + return arizona_exec_with_sysclk(arizona, wm5110_sleep_patch_wseq);
> +}
> +
> #ifdef CONFIG_PM
> static int arizona_runtime_resume(struct device *dev)
> {
> @@ -913,6 +932,16 @@ int arizona_dev_init(struct arizona *arizona)
> goto err_reset;
> }
> break;
> + case WM5110:
> + case WM8280:
> + ret = wm5110_apply_sleep_patch(arizona);
> + if (ret != 0) {

if (ret) {

> + dev_err(arizona->dev,
> + "Failed to apply sleep patch: %d\n",
> + ret);
> + goto err_reset;
> + }
> + break;
> default:
> break;
> }

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog