From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752755AbbCWPCV (ORCPT ); Mon, 23 Mar 2015 11:02:21 -0400 Received: from mail-wg0-f50.google.com ([74.125.82.50]:33837 "EHLO mail-wg0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752185AbbCWPCT (ORCPT ); Mon, 23 Mar 2015 11:02:19 -0400 Date: Mon, 23 Mar 2015 15:02:13 +0000 From: Lee Jones To: Pavel Machek Cc: Jacek Anaszewski , linux-leds@vger.kernel.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, kyungmin.park@samsung.com, cooloney@gmail.com, rpurdie@rpsys.net, sakari.ailus@iki.fi, s.nawrocki@samsung.com, Andrzej Hajda , Chanwoo Choi Subject: Re: [PATCH/RFC v13 04/13] DT: Add documentation for the mfd Maxim max77693 Message-ID: <20150323150213.GN24804@x1> References: <1426175114-14876-1-git-send-email-j.anaszewski@samsung.com> <1426175114-14876-5-git-send-email-j.anaszewski@samsung.com> <20150323120743.GG24422@x1> <20150323142202.GA23919@amd> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20150323142202.GA23919@amd> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 23 Mar 2015, Pavel Machek wrote: > On Mon 2015-03-23 12:07:43, Lee Jones wrote: > > This patch requires a DT Ack. > > No, it requires DT people to be notified -- and they were, few times > by now. > > They clearly don't care. Well fortunately for the Kernel community, I do care. And as this patch adds 3 new DT properties, has been through many iterations already with vast changes made over that period and there is still some controversy looming, I'm saying that it _does_ require a DT Ack. > > > This patch adds device tree binding documentation for > > > the flash cell of the Maxim max77693 multifunctional device. > > > > > > Signed-off-by: Jacek Anaszewski > > > Signed-off-by: Andrzej Hajda > > > Acked-by: Kyungmin Park > > > Cc: Lee Jones > > > Cc: Chanwoo Choi > > > Cc: Bryan Wu > > > Cc: Richard Purdie > > Acked-by: Pavel Machek > > > > > diff --git a/Documentation/devicetree/bindings/mfd/max77693.txt b/Documentation/devicetree/bindings/mfd/max77693.txt > > > index 38e6440..15c546e 100644 > > > --- a/Documentation/devicetree/bindings/mfd/max77693.txt > > > +++ b/Documentation/devicetree/bindings/mfd/max77693.txt > > > @@ -76,7 +76,53 @@ Optional properties: > > > Valid values: 4300000, 4700000, 4800000, 4900000 > > > Default: 4300000 > > > > > > +- led : the LED submodule device node > > > + > > > +There are two LED outputs available - FLED1 and FLED2. Each of them can > > > +control a separate LED or they can be connected together to double > > > +the maximum current for a single connected LED. One LED is represented > > > +by one child node. > > > + > > > +Required properties: > > > +- compatible : Must be "maxim,max77693-led". > > > + > > > +Optional properties: > > > +- maxim,trigger-type : Flash trigger type. > > > + Possible trigger types: > > > + LEDS_TRIG_TYPE_EDGE (0) - Rising edge of the signal triggers > > > + the flash, > > > + LEDS_TRIG_TYPE_LEVEL (1) - Strobe pulse length controls duration > > > + of the flash. > > > +- maxim,boost-mode : > > > + In boost mode the device can produce up to 1.2A of total current > > > + on both outputs. The maximum current on each output is reduced > > > + to 625mA then. If not enabled explicitly, boost setting defaults to > > > + LEDS_BOOST_FIXED in case both current sources are used. > > > + Possible values: > > > + LEDS_BOOST_OFF (0) - no boost, > > > + LEDS_BOOST_ADAPTIVE (1) - adaptive mode, > > > + LEDS_BOOST_FIXED (2) - fixed mode. > > > +- maxim,boost-mvout : Output voltage of the boost module in millivolts. > > > +- maxim,mvsys-min : Low input voltage level in millivolts. Flash is not fired > > > + if chip estimates that system voltage could drop below this level due > > > + to flash power consumption. > > > + > > > +Required properties of the LED child node: > > > +- led-sources : see Documentation/devicetree/bindings/leds/common.txt; > > > + device current output identifiers: 0 - FLED1, 1 - FLED2 > > > + > > > +Optional properties of the LED child node: > > > +- label : see Documentation/devicetree/bindings/leds/common.txt > > > +- max-microamp : see Documentation/devicetree/bindings/leds/common.txt > > > + Range: 15625 - 250000 > > > +- flash-max-microamp : see Documentation/devicetree/bindings/leds/common.txt > > > + Range: 15625 - 1000000 > > > +- flash-timeout-us : see Documentation/devicetree/bindings/leds/common.txt > > > + Range: 62500 - 1000000 > > > + > > > Example: > > > +#include > > > + > > > max77693@66 { > > > compatible = "maxim,max77693"; > > > reg = <0x66>; > > > @@ -117,5 +163,20 @@ Example: > > > maxim,thermal-regulation-celsius = <75>; > > > maxim,battery-overcurrent-microamp = <3000000>; > > > maxim,charge-input-threshold-microvolt = <4300000>; > > > + > > > + led { > > > + compatible = "maxim,max77693-led"; > > > + maxim,trigger-type = ; > > > + maxim,boost-mode = ; > > > + maxim,boost-mvout = <5000>; > > > + maxim,mvsys-min = <2400>; > > > + > > > + camera_flash: flash-led { > > > + label = "max77693-flash"; > > > + led-sources = <0>, <1>; > > > + max-microamp = <500000>; > > > + flash-max-microamp = <1250000>; > > > + flash-timeout-us = <1000000>; > > > + }; > > > }; > > > }; > > > > > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog