From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752397AbbCWPLa (ORCPT ); Mon, 23 Mar 2015 11:11:30 -0400 Received: from mail.skyhub.de ([78.46.96.112]:34766 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752754AbbCWPLY (ORCPT ); Mon, 23 Mar 2015 11:11:24 -0400 Date: Mon, 23 Mar 2015 16:09:42 +0100 From: Borislav Petkov To: Ingo Molnar Cc: Jim Kukunas , Linux Kernel , tom.zanussi@linux.intel.com, Arjan van de Ven , "H. Peter Anvin" , tglx@linutronix.de, mingo@redhat.com, x86@kernel.org Subject: Re: [PATCH 11/11] x86/xip: update _va() and _pa() macros Message-ID: <20150323150942.GF31992@pd.tnic> References: <1427096800-30452-1-git-send-email-james.t.kukunas@linux.intel.com> <1427096800-30452-12-git-send-email-james.t.kukunas@linux.intel.com> <20150323080956.GC25620@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20150323080956.GC25620@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 23, 2015 at 09:09:56AM +0100, Ingo Molnar wrote: > > @@ -37,8 +38,15 @@ static inline void copy_user_page(void *to, void *from, unsigned long vaddr, > > alloc_page_vma(GFP_HIGHUSER | __GFP_ZERO | movableflags, vma, vaddr) > > #define __HAVE_ARCH_ALLOC_ZEROED_USER_HIGHPAGE > > > > + > > +#ifdef CONFIG_XIP_KERNEL /* TODO special case text translations */ > > +#define __pa(x) slow_virt_to_phys((void *)(x)) > > +#define __pa_nodebug slow_virt_to_phys((void *)(x)) This macro looks like it is missing an arg too. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. --