From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753137AbbCWPHx (ORCPT <rfc822;w@1wt.eu>);
	Mon, 23 Mar 2015 11:07:53 -0400
Received: from mout.kundenserver.de ([212.227.17.24]:60706 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752216AbbCWPHt (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 23 Mar 2015 11:07:49 -0400
From: Arnd Bergmann <arnd@linaro.org>
Organization: Linaro Ltd
To: Richard Cochran <richardcochran@gmail.com>
Subject: Re: [PATCH net-next V2 20/23] ptp: dp83640: convert to the 64 bit get/set time methods.
Date: Mon, 23 Mar 2015 16:06:28 +0100
User-Agent: KMail/1.12.2 (Linux/3.8.0-35-generic; KDE/4.3.2; x86_64; ; )
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        Amir Vadai <amirv@mellanox.com>, Ariel Elior <ariel.elior@qlogic.com>,
        Baolin Wang <baolin.wang@linaro.org>,
        Ben Hutchings <ben@decadent.org.uk>,
        Bruce Allan <bruce.w.allan@intel.com>,
        Carolyn Wyborny <carolyn.wyborny@intel.com>,
        Chris Metcalf <cmetcalf@ezchip.com>,
        David Miller <davem@davemloft.net>, Frank Li <Frank.Li@freescale.com>,
        Giuseppe Cavallaro <peppe.cavallaro@st.com>,
        Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
        John Stultz <john.stultz@linaro.org>,
        Luwei Zhou <b45643@freescale.com>,
        Matthew Vick <matthew.vick@intel.com>,
        Michael Chan <mchan@broadcom.com>,
        Prashant Sreedharan <prashant@broadcom.com>,
        Shradha Shah <sshah@solarflare.com>,
        Solarflare linux maintainers <linux-net-drivers@solarflare.com>,
        Sonic Zhang <sonic.zhang@analog.com>,
        Stefan =?iso-8859-1?q?S=F8rensen?= 
	<stefan.sorensen@spectralink.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Tom Lendacky <thomas.lendacky@amd.com>
References: <cover.1426973658.git.richardcochran@gmail.com> <201503221848.02226.arnd@linaro.org> <20150323081040.GA4779@localhost.localdomain>
In-Reply-To: <20150323081040.GA4779@localhost.localdomain>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <201503231606.29346.arnd@linaro.org>
X-Provags-ID: V03:K0:p4cEoN+xLrGbZ+v5XkG3vdukfc+P9OQAht/sbJs3jNIBybxxwdG
 xz6yYaNinD+IR9PeL5IiB/QtiWt3qOR23xhZZevtdL5gzRvt8AVndqZh/Ih86EUZ3S5U77I
 m3ZUjiyDLun0oL+b4lS1BWclJ9hwaktLL9qZPGG7N4L+19A6TietPh1yKjGC4yrIDHjFRgl
 nQSUywr6fwq4hY5jFQsSg==
X-UI-Out-Filterresults: notjunk:1;
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Monday 23 March 2015, Richard Cochran wrote:
> 
> On Sun, Mar 22, 2015 at 06:48:02PM +0100, Arnd Bergmann wrote:
> > Ok, got it. The code looks correct then, though I'd like to see the use
> > of 'timespec' pushed out as far as possible. How about changing the
> > type for tdr_write() as well here?
> > 
> > tdr_write() itself should be fine until 2106, as it writes an unsigned number,
> > but it's probably good to document that inside of that function.
> 
> Arnd, thanks for the careful review.  I will work out follow up
> patches for this driver and the i210 (igb) to address the remaining
> issues.  For this series, lets leave tdr_write as is now, but I will
> surely take another look for the fix.
> 

Ok, sounds good.

	Arnd