From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753030AbbCWRUN (ORCPT ); Mon, 23 Mar 2015 13:20:13 -0400 Received: from down.free-electrons.com ([37.187.137.238]:58792 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752342AbbCWRUK (ORCPT ); Mon, 23 Mar 2015 13:20:10 -0400 Date: Mon, 23 Mar 2015 09:54:05 -0700 From: Maxime Ripard To: Hans de Goede Cc: Daniel Lezcano , Chen-Yu Tsai , Thomas Gleixner , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 0/5] clocksource: sun5i: Support parent clock rate changes Message-ID: <20150323165405.GB15676@lukather> References: <1425550856-12928-1-git-send-email-maxime.ripard@free-electrons.com> <20150319225344.GF4255@lukather> <550C28EC.2040800@linaro.org> <20150320205655.GJ4255@lukather> <550D4B6C.2020607@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="8GpibOaaTibBMecb" Content-Disposition: inline In-Reply-To: <550D4B6C.2020607@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --8GpibOaaTibBMecb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Mar 21, 2015 at 11:43:56AM +0100, Hans de Goede wrote: > Hi, >=20 > On 20-03-15 21:56, Maxime Ripard wrote: > >Hi, > > > >On Fri, Mar 20, 2015 at 03:04:28PM +0100, Daniel Lezcano wrote: > >>On 03/19/2015 11:53 PM, Maxime Ripard wrote: > >>>Hi Daniel, > >>> > >>>On Thu, Mar 05, 2015 at 11:20:51AM +0100, Maxime Ripard wrote: > >>>>Hi, > >>>> > >>>>The Allwinner HS timers have the AHB clock as their parent > >>>>clock. Since this clock is shared with other devices, we could very > >>>>well have another driver requesting a rate change of that clock, > >>>>making our timer change frequency at the same time. > >>>> > >>>>This is especially true on the A31, where the DMA controller needs to > >>>>do such a rate change, making the HS timer unreliable at the time on > >>>>the A31. > >>>> > >>>>This serie makes some cleanups and implements clock notifiers to be > >>>>able to reflect such rate changes and make sure that the timer is > >>>>always working. > >>>> > >>>>Maxime > >>>> > >>>>Changes from v2: > >>>> - Rebased on top of v4.0-rc1 > >>>> - Removed the local_irq_save/restore around clockevents_update_freq > >>>> > >>>>Changes from v1: > >>>> - Changed the interrupt name to its previous value > >>>> > >>>>Maxime Ripard (5): > >>>> clocksource: sun5i: Switch to request_irq > >>>> clocksource: sun5i: Use of_io_request_and_map > >>>> clocksource: sun5i: Remove sched_clock > >>>> clocksource: sun5i: Refactor the current code > >>>> clocksource: sun5i: Add clock notifiers > >>> > >>>Have these patches been merged? > >>> > >>>If not, it woulde be great if the third one ("clocksource: sun5i: > >>>Remove sched_clock") was merged for 4.0. > >>> > >>>The sched_clock we use on some system is this timer's, and since we > >>>started using cpufreq, the cpu clock (that is one of the timer's clock > >>>indirect parent) now changes, along with the actual sched_clock rate. > >>> > >>>We can safely remove the sched_clock on those systems, since we have > >>>other reliable sched_clock in the system. > >> > >>Ok, I applied the patch for v4.0-rc5 but I had to fix a conflict and ch= ange > >>the changelog. > > > >It looks fine. > > > >Note that the rest of the serie should also be merged, this is just a > >temporary measure for 4.0. > > > >>Mind to test it works ? > >> > >>git.linaro.org/people/daniel.lezcano/linux.git clockevents/v4.0-rc4 > > > >Unfortunately, I won't have access to my boards for ~10 days due to > >travel to ELC. Chen-Yu, Hans, could you test this and see if it works? >=20 > I've just given this a test run on an A20 board, using the dmesg > timestamps are off reproducer discussed before, and the problem no > longer reproduces on the clockevents/4.0-rc4 branch, and everything > else still seems to work fine. Great, thanks! Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --8GpibOaaTibBMecb Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVEEUtAAoJEBx+YmzsjxAgw8oP/10x2aeT0F3F8Qt9Yghr97wl JUpeZPtMm7g49Tsyuajsffv+ghJP8wwyAzXZkz2rSGe1+BHIvk80gENWHtcpktMQ TcE0jxFMoRpYQcXNlK9l+VB4ZI4kFaMXDb5I46fP04bXfMWmYhQU+zfYbGL/QgU7 1JTvdsX+1+3y9B5nh5U2v+IN524UZwwjQwToo/I7IpMAJ9+0dpJio6V7WFfXCCQs 39T+HgKlBdvhzJ98R7ZSyRqcBn3LyLPeBtbuTLDqwdo+umPh4YRAEH1YgAPyuie6 w5UpwlM2HgavtyHoNSNHtX+xMrQA3x+Pnl6DGRBsOBtB7LCN9u2Kas8dS/MJGE30 FSym1ttP2s8/MTq50j9/cLib+JbW9qLCb/GOOZIcYGwhWb0b/rIKn9NeEf0OeEQ/ j3zJG0jBIYNEkYeKF9JSqpRwvi4gGH5iLD5G/qDkyX3vrrWDDtAVceXCKRBgjSQW gf7nqEUxhaYZeNsPdS2UhLj648mZB072CTQn47VlZ10B3CVxcmSw5jCRa7M0Npbn Ug7D5HReykV8KwnHYWp6H0Kt/o4R167XFG1FQNX0kQLNeIdu+/DtgZCdz9KKyhw7 UmS1XyP1clLVjUUBHXMgmNtkNw3RxKilKsLdhu4a6gmkXy22vTgyI/nF7/41uqTM ukdOias1Mi7ezUq3BDYJ =6l4o -----END PGP SIGNATURE----- --8GpibOaaTibBMecb--