From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752984AbbCWREV (ORCPT <rfc822;w@1wt.eu>);
	Mon, 23 Mar 2015 13:04:21 -0400
Received: from service87.mimecast.com ([91.220.42.44]:55637 "EHLO
	service87.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752214AbbCWREU convert rfc822-to-8bit (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 23 Mar 2015 13:04:20 -0400
Date: Mon, 23 Mar 2015 17:04:17 +0000
From: Javi Merino <javi.merino@arm.com>
To: Jeff Epler <jepler@unpythonic.net>
Cc: "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
        "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Daniel Vetter <daniel.vetter@intel.com>,
        Jani Nikula <jani.nikula@linux.intel.com>,
        David Airlie <airlied@linux.ie>, "Darrick J. Wong" <djwong@us.ibm.com>,
        Guenter Roeck <linux@roeck-us.net>, Alex Elder <elder@ieee.org>
Subject: Re: [PATCH 1/4] kernel.h: Implement DIV_ROUND_CLOSEST_ULL
Message-ID: <20150323170416.GA6161@e104805>
References: <1426850083-11049-1-git-send-email-javi.merino@arm.com>
 <1426850083-11049-2-git-send-email-javi.merino@arm.com>
 <20150323123404.GC17049@unpythonic.net>
MIME-Version: 1.0
In-Reply-To: <20150323123404.GC17049@unpythonic.net>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-OriginalArrivalTime: 23 Mar 2015 17:04:16.0530 (UTC) FILETIME=[65218720:01D0658B]
X-MC-Unique: 115032317041706101
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Content-Disposition: inline
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Mar 23, 2015 at 12:34:04PM +0000, Jeff Epler wrote:
> On Fri, Mar 20, 2015 at 11:14:40AM +0000, Javi Merino wrote:
> > +/*
> > + * Same as above but for u64 dividends.  divisor must be a 32-bit
> > + * number.
> > + */
> > +#define DIV_ROUND_CLOSEST_ULL(x, divisor)(		\
> > +{							\
> > +	unsigned long long _tmp = (x) + (divisor) / 2;	\
> > +	do_div(_tmp, divisor);				\
> > +	_tmp;						\
> > +}							\
> > +)
> 
> The macro evaluates 'divisor' twice.

Good catch.  That needs to be fixed.  I could do the typeof trick that
DIV_ROUND_CLOSEST() does but it's probably better to just create a
static function as Alex Elder suggests.  I'll send a v2 tomorrow with
a static function instead.

Cheers,
Javi