From: "Pali Rohár" <pali.rohar@gmail.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Santiago Gala <sgala@apache.org>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: ALPS - Detect trackstick presence for v7 protocol
Date: Mon, 23 Mar 2015 18:02:28 +0100 [thread overview]
Message-ID: <201503231802.28977@pali> (raw)
In-Reply-To: <550FFB84.6000609@redhat.com>
[-- Attachment #1: Type: Text/Plain, Size: 1309 bytes --]
On Monday 23 March 2015 12:39:48 Hans de Goede wrote:
> Hi,
>
> On 22-03-15 14:46, Pali Rohár wrote:
> > This patch adds detection of trackstick for v7 protocol
> > devices. Code in this patch is used in official Dell
> > touchpad linux drivers for Dell models: Dell Latitude
> > E5250/5250, E5450/5450, E5550/5550
> >
> > Detection code and base reg for alps v3 rushmore and v7
> > devices is exacly same.
> >
> > Also user in bug
> > https://bugzilla.kernel.org/show_bug.cgi?id=94801 reported
> > that Toshiba Sattellite Z30-A-1DG has only alps v7 touchpad
> > device without trackstick and kernel reports to userspace
> > also redundant trackstick device.
> >
> > Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
>
> Looks good, but has this been tested on a laptop which
> actually has a v7 pad + trackstick? I would like to see this
> actually tested on at least one such laptop before it gets
> merged.
>
> Regards,
>
> Hans
>
I did not tested my patch on any v7 touchpad-only laptop.
But I guess Dell should have tested it... Of course we can wait
until somebody test this patch and after that we will merge it.
@Santiago: Can you test this patch? You also have v7 touchpad
only laptop (without trackstick).
--
Pali Rohár
pali.rohar@gmail.com
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2015-03-23 17:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-22 13:46 [PATCH] Input: ALPS - Detect trackstick presence for v7 protocol Pali Rohár
2015-03-23 11:39 ` Hans de Goede
2015-03-23 17:02 ` Pali Rohár [this message]
2015-03-24 7:27 ` Hans de Goede
[not found] ` <CAPXTYCXrvFDbvEDkEQxkcJ5y1OHx7Ldm+bu-LnWfigjTj6gECw@mail.gmail.com>
2015-03-24 16:46 ` Pali Rohár
2015-03-24 17:01 ` Dmitry Torokhov
2015-03-29 3:59 ` Dmitry Torokhov
2015-05-28 7:39 ` Pali Rohár
[not found] ` <201503271816.11723@pali>
[not found] ` <CAPXTYCX13Y7FY7o9CPPQXchSVYiJ415o_yxOFruO-scTV=X27w@mail.gmail.com>
2015-03-27 20:08 ` Pali Rohár
[not found] ` <CAPXTYCVGpm27naqu723f8kC0h75TT6XSN0X_EWCu6cXJS0G2kg@mail.gmail.com>
2015-03-27 20:54 ` Pali Rohár
[not found] ` <CAPXTYCUqibXqTBf8VKGKixKeM49LhucxFDhS+04fUsiSEKMKOg@mail.gmail.com>
2015-03-28 3:43 ` Dmitry Torokhov
2015-03-28 8:51 ` Pali Rohár
2016-01-05 16:44 ` Pali Rohár
2016-01-06 8:12 ` Hans de Goede
2016-01-06 23:55 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201503231802.28977@pali \
--to=pali.rohar@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=hdegoede@redhat.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sgala@apache.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).