From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753124AbbCWUGc (ORCPT ); Mon, 23 Mar 2015 16:06:32 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:39148 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752120AbbCWUGa (ORCPT ); Mon, 23 Mar 2015 16:06:30 -0400 Date: Mon, 23 Mar 2015 13:06:28 -0700 From: Stephen Boyd To: Lee Jones Cc: "Ivan T. Ivanov" , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Samuel Ortiz , Stanimir Varbanov , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH v3] mfd: Add specific compatible strings for Qualcomm's SPMI PMIC's Message-ID: <20150323200628.GA21712@codeaurora.org> References: <1426589244-16740-1-git-send-email-iivanov@mm-sol.com> <20150323132109.GF24804@x1> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150323132109.GF24804@x1> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/23, Lee Jones wrote: > I want to see if Stephen B is now happy with this. > > Not CC'ing him as a previous review is bad form IMO. > > > Some of the PMIC's could have specific regmap configuration > > tables in future, so add specific compatible strings for known > > PMIC's. Also print runtime detected chip revision information. > > > > Signed-off-by: Ivan T. Ivanov > > --- Looks OK to me. Acked-by: Stephen Boyd -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project