From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753406AbbCWXUg (ORCPT ); Mon, 23 Mar 2015 19:20:36 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:48881 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752614AbbCWXUf (ORCPT ); Mon, 23 Mar 2015 19:20:35 -0400 Date: Mon, 23 Mar 2015 22:04:40 +0100 From: Greg Kroah-Hartman To: Sudip Mukherjee Cc: Benjamin Romer , David Kershner , sparmaintainer@unisys.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: unisys: handle major number properly Message-ID: <20150323210440.GA22956@kroah.com> References: <1426604484-7770-1-git-send-email-sudipm.mukherjee@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1426604484-7770-1-git-send-email-sudipm.mukherjee@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 17, 2015 at 08:31:24PM +0530, Sudip Mukherjee wrote: > fixed the handling of dev_t and the major number. > now the major and minor number is passed to the init function. > similarly in the cleanup function dev_t is passed to unregister it. > > Signed-off-by: Sudip Mukherjee > --- > drivers/staging/unisys/visorchipset/file.c | 18 ++++++++---------- > drivers/staging/unisys/visorchipset/file.h | 4 ++-- > .../staging/unisys/visorchipset/visorchipset_main.c | 10 +++------- > 3 files changed, 13 insertions(+), 19 deletions(-) This doesn't apply anymore, due to other changes recently to this driver. But even if it did, I don't think it is correct. I really don't understand what you are trying to do here. I think you just merged two different major numbers togther, which isn't good at all. But if you didn't, then why is this patch doing different things to different files (hint, only do one thing per file.) Also, why does the driver have multiple major numbers? Isn't a single major good enough? How many does it need? For what does it use them for? Totally confused, greg k-h