From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753555AbbCWV50 (ORCPT ); Mon, 23 Mar 2015 17:57:26 -0400 Received: from e33.co.us.ibm.com ([32.97.110.151]:51297 "EHLO e33.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752214AbbCWV5Y (ORCPT ); Mon, 23 Mar 2015 17:57:24 -0400 Date: Mon, 23 Mar 2015 14:55:19 -0700 From: Sukadev Bhattiprolu To: Michael Ellerman Cc: Paul Mackerras , peterz@infradead.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [8/9] powerpc/hv-24x7: Break up single_24x7_request Message-ID: <20150323215519.GA6013@us.ibm.com> References: <1424210434-28070-9-git-send-email-sukadev@linux.vnet.ibm.com> <20150317022358.8DE1D14011D@ozlabs.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150317022358.8DE1D14011D@ozlabs.org> X-Operating-System: Linux 2.0.32 on an i486 User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15032321-0009-0000-0000-000009A6F12F Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Michael Ellerman [mpe@ellerman.id.au] wrote: | > +static void start_24x7_get_data(struct hv_24x7_request_buffer *request_buffer, | > + struct hv_24x7_data_result_buffer *result_buffer) | > +{ | | Just init_24x7_request() ? Sure. | | > + | > + memset(request_buffer, 0, 4096); | > + memset(result_buffer, 0, 4096); | > + | > + request_buffer->interface_version = HV_24X7_IF_VERSION_CURRENT; | > + /* memset above set request_buffer->num_requests to 0 */ | > +} | > + | > +/* | > + * Commit (i.e perform) the H_GET_24x7_DATA hcall using the data collected | > + * by 'start_24x7_get_data()' and 'add_event_to_24x7_request()'. | > + */ | > +static int commit_24x7_get_data(struct hv_24x7_request_buffer *request_buffer, | > + struct hv_24x7_data_result_buffer *result_buffer) | > +{ | | It don't like "commit" that is a loaded term. | | Just make_24x7_request() perhaps? Sure. Thanks Sukadev