From: Namhyung Kim <namhyung@kernel.org>
To: Joonsoo Kim <js1304@gmail.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Jiri Olsa <jolsa@redhat.com>, LKML <linux-kernel@vger.kernel.org>,
David Ahern <dsahern@gmail.com>, Minchan Kim <minchan@kernel.org>
Subject: Re: [PATCH 4/5] perf kmem: Support sort keys on page analysis
Date: Tue, 24 Mar 2015 09:20:25 +0900 [thread overview]
Message-ID: <20150324002025.GK2782@sejong> (raw)
In-Reply-To: <CAAmzW4MYsJXi82e8G7xi8G9x36MYxGMfXzPgjwqfZt_Q8s+GJA@mail.gmail.com>
On Tue, Mar 24, 2015 at 02:27:09AM +0900, Joonsoo Kim wrote:
> 2015-03-23 15:30 GMT+09:00 Namhyung Kim <namhyung@kernel.org>:
> > Add new sort keys for page: page, order, mtype, gfp - existing
> > 'bytes', 'hit' and 'callsite' sort keys also work for page. Note that
> > -s/--sort option should be preceded by either of --slab or --page
> > option to determine where the sort keys applies.
> >
> > Now it properly groups and sorts allocation stats - so same
> > page/caller with different order/mtype/gfp will be printed on a
> > different line.
>
> How about storing/printing pid, too?
> It would be helpful to distinguish who allocates the page.
That's also in my TODO list. :)
Thanks,
Namhyung
next prev parent reply other threads:[~2015-03-24 0:27 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-23 6:30 [PATCHSET 0/5] perf kmem: Implement page allocation analysis (v3) Namhyung Kim
2015-03-23 6:30 ` [PATCH 1/5] perf kmem: Print big numbers using thousands' group Namhyung Kim
2015-03-23 14:08 ` Arnaldo Carvalho de Melo
2015-03-23 23:35 ` Namhyung Kim
2015-03-24 16:31 ` [tip:perf/core] " tip-bot for Namhyung Kim
2015-03-23 6:30 ` [PATCH 2/5] perf kmem: Analyze page allocator events also Namhyung Kim
2015-03-23 17:32 ` Joonsoo Kim
2015-03-24 0:18 ` Namhyung Kim
2015-03-24 5:26 ` Joonsoo Kim
2015-03-24 6:05 ` Namhyung Kim
2015-03-24 7:08 ` Ingo Molnar
2015-03-24 13:17 ` Namhyung Kim
2015-03-23 6:30 ` [PATCH 3/5] perf kmem: Implement stat --page --caller Namhyung Kim
2015-03-23 6:30 ` [PATCH 4/5] perf kmem: Support sort keys on page analysis Namhyung Kim
2015-03-23 17:27 ` Joonsoo Kim
2015-03-24 0:20 ` Namhyung Kim [this message]
2015-03-23 6:30 ` [PATCH 5/5] perf kmem: Add --live option for current allocation stat Namhyung Kim
2015-03-23 17:23 ` [PATCHSET 0/5] perf kmem: Implement page allocation analysis (v3) Joonsoo Kim
2015-03-23 23:57 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150324002025.GK2782@sejong \
--to=namhyung@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=dsahern@gmail.com \
--cc=jolsa@redhat.com \
--cc=js1304@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=minchan@kernel.org \
--cc=mingo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox