From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753492AbbCXGek (ORCPT ); Tue, 24 Mar 2015 02:34:40 -0400 Received: from mail-wi0-f172.google.com ([209.85.212.172]:38598 "EHLO mail-wi0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751602AbbCXGeg (ORCPT ); Tue, 24 Mar 2015 02:34:36 -0400 Date: Tue, 24 Mar 2015 07:34:31 +0100 From: Ingo Molnar To: Denys Vlasenko Cc: Andy Lutomirski , Denys Vlasenko , Linus Torvalds , Steven Rostedt , Borislav Petkov , "H. Peter Anvin" , Oleg Nesterov , Frederic Weisbecker , Alexei Starovoitov , Will Drewry , Kees Cook , X86 ML , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] x86: vdso32/syscall.S: do not load __USER32_DS to %ss Message-ID: <20150324063430.GB26302@gmail.com> References: <1427129240-15543-1-git-send-email-dvlasenk@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Denys Vlasenko wrote: > On Mon, Mar 23, 2015 at 9:38 PM, Andy Lutomirski wrote: > > Actually, I want to remove the added comment in the code. I don't see > > why we should have a specific comment about SS and not about, say, CS, > > ESP, or anything else. OK? > > Ok. Might be nice to place a more generic description there, which registers are expected to be saved by user-space calling in here, etc. Thanks, Ingo