From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752481AbbCXIAC (ORCPT ); Tue, 24 Mar 2015 04:00:02 -0400 Received: from mga02.intel.com ([134.134.136.20]:15155 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752130AbbCXH77 (ORCPT ); Tue, 24 Mar 2015 03:59:59 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,457,1422950400"; d="scan'208";a="669676296" Date: Tue, 24 Mar 2015 15:41:59 +0800 From: Wanpeng Li To: Jaegeuk Kim Cc: Changman Lee , Chao Yu , linux-f2fs-devel@lists.sourceforge.net, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Wanpeng Li Subject: Re: [PATCH v3 2/2] f2fs: enable fast symlink by utilizing inline data Message-ID: <20150324074159.GA2759@kernel> Reply-To: Wanpeng Li References: <1427163628-3840-1-git-send-email-wanpeng.li@linux.intel.com> <1427163628-3840-2-git-send-email-wanpeng.li@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1427163628-3840-2-git-send-email-wanpeng.li@linux.intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ping this one. On Tue, Mar 24, 2015 at 10:20:28AM +0800, Wanpeng Li wrote: >Fast symlink can utilize inline data flow to avoid using any >i_addr region, since we need to handle many cases such as >truncation, roll-forward recovery, and fsck/dump tools. > >Signed-off-by: Wanpeng Li >--- > fs/f2fs/inline.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/fs/f2fs/inline.c b/fs/f2fs/inline.c >index d3e0599..375d2c7 100644 >--- a/fs/f2fs/inline.c >+++ b/fs/f2fs/inline.c >@@ -21,7 +21,7 @@ bool f2fs_may_inline(struct inode *inode) > if (f2fs_is_atomic_file(inode)) > return false; > >- if (!S_ISREG(inode->i_mode)) >+ if (!S_ISREG(inode->i_mode) && !S_ISLNK(inode->i_mode)) > return false; > > if (i_size_read(inode) > MAX_INLINE_DATA) >-- >2.1.0