From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752931AbbCXHw3 (ORCPT ); Tue, 24 Mar 2015 03:52:29 -0400 Received: from mail-pa0-f41.google.com ([209.85.220.41]:34742 "EHLO mail-pa0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751665AbbCXHw1 (ORCPT ); Tue, 24 Mar 2015 03:52:27 -0400 Date: Tue, 24 Mar 2015 13:22:16 +0530 From: Sudip Mukherjee To: Willy Tarreau Cc: Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: panel: fix lcd type Message-ID: <20150324075216.GA6606@sudip-PC> References: <1427172490-4192-1-git-send-email-sudipm.mukherjee@gmail.com> <20150324070411.GA23021@1wt.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150324070411.GA23021@1wt.eu> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 24, 2015 at 08:04:11AM +0100, Willy Tarreau wrote: > Hi Sudip! > > On Tue, Mar 24, 2015 at 10:18:10AM +0530, Sudip Mukherjee wrote: > > the lcd type as defined in the Kconfig is not matching in the code. > > as a result the rs, rw and en pins were getting interchanged. > > Kconfig defines the value of PANEL_LCD to be 1 if we select custom > > configuration but in the code LCD_TYPE_CUSTOM is defined as 5. > > > > my hardware is LCD_TYPE_CUSTOM, but the pins were assigned to it > > as pins of LCD_TYPE_OLD, and it was not working. > > Now values are corrected with referenece to the values defined in > > Kconfig and it is working. > > checked on JHD204A lcd with LCD_TYPE_CUSTOM configuration. > > > > Signed-off-by: Sudip Mukherjee > > OK but you also need to hange the MODULE_PARM_DESC(lcd_type) to > match these new settings. Given that this is a bug, you can even > think about adding a Cc: stable tag. i missed seeing that MODULE_PARM_DESC. i wanted to have your confirmation first before ccing stable. will cc stable in v2. but before that i think i need to read the Documentation about how to cc stable for those many stable versions till 2.6.32 regards sudip > > Thanks, > Willy >