From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753264AbbCXH5L (ORCPT ); Tue, 24 Mar 2015 03:57:11 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:43087 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751713AbbCXH5H (ORCPT ); Tue, 24 Mar 2015 03:57:07 -0400 Date: Tue, 24 Mar 2015 10:57:08 +0300 From: Dan Carpenter To: Ragavendra Nagraj Cc: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: sm750fb: Fixed C99 comments warnings Message-ID: <20150324075708.GM10964@mwanda> References: <20150324045154.GA12298@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150324045154.GA12298@localhost.localdomain> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 23, 2015 at 09:51:54PM -0700, Ragavendra Nagraj wrote: > diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c > index 02f9326..1fb00a4 100644 > --- a/drivers/staging/sm750fb/ddk750_chip.c > +++ b/drivers/staging/sm750fb/ddk750_chip.c > @@ -17,7 +17,7 @@ logical_chip_type_t getChipType(void) > char physicalRev; > logical_chip_type_t chip; > > - physicalID = devId750;//either 0x718 or 0x750 > + physicalID = devId750;/*either 0x718 or 0x750*/ This should be: physicalID = devId750; /* either 0x718 or 0x750 */ > @@ -501,7 +501,7 @@ unsigned int calcPllValue(unsigned int request_orig,pll_value_t *pll) > } > } > > - //printk("Finally: pll->n[%lu],m[%lu],od[%lu],pod[%lu]\n",pll->N,pll->M,pll->OD,pll->POD); > + /*printk("Finally: pll->n[%lu],m[%lu],od[%lu],pod[%lu]\n",pll->N,pll->M,pll->OD,pll->POD);*/ Just delete this dead code. Please redo. regards, dan carpenter