Re: [PATCH] staging: panel: fix lcd type

Sudip Mukherjee
2015-03-24T07:52:29Z

On Tue, Mar 24, 2015 at 08:04:11AM +0100, Willy Tarreau wrote:
> Hi Sudip!
>
> On Tue, Mar 24, 2015 at 10:18:10AM +0530, Sudip Mukherjee wrote:
> > the lcd type as defined in the Kconfig is not matching in the code.
> > as a result the rs, rw and en pins were getting interchanged.
> > Kconfig defines the value of PANEL_LCD to be 1 if we select custom
> > configuration but in the code LCD_TYPE_CUSTOM is defined as 5.
> >
> > my hardware is LCD_TYPE_CUSTOM, but the pins were assigned to it
> > as pins of LCD_TYPE_OLD, and it was not working.
> > Now values are corrected with referenece to the values defined in
> > Kconfig and it is working.
> > checked on JHD204A lcd with LCD_TYPE_CUSTOM configuration.
> >
> > Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
>
> OK but you also need to hange the MODULE_PARM_DESC(lcd_type) to
> match these new settings. Given that this is a bug, you can even
> think about adding a Cc: stable tag.
i missed seeing that MODULE_PARM_DESC. i wanted to have your
confirmation first before ccing stable.

will cc stable in v2.
but before that i think i need to read the Documentation about how to
cc stable for those many stable versions till 2.6.32

regards
sudip

>
> Thanks,
> Willy
>