From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752462AbbCXInc (ORCPT <rfc822;w@1wt.eu>);
	Tue, 24 Mar 2015 04:43:32 -0400
Received: from mail-pd0-f169.google.com ([209.85.192.169]:34231 "EHLO
	mail-pd0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752139AbbCXIn1 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 24 Mar 2015 04:43:27 -0400
Date: Tue, 24 Mar 2015 14:13:16 +0530
From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Benjamin Romer <benjamin.romer@unisys.com>,
        David Kershner <david.kershner@unisys.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        devel@driverdev.osuosl.org, sparmaintainer@unisys.com,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: unisys: handle major number properly
Message-ID: <20150324084316.GA7113@sudip-PC>
References: <1426604484-7770-1-git-send-email-sudipm.mukherjee@gmail.com>
 <20150324083247.GP10964@mwanda>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150324083247.GP10964@mwanda>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Mar 24, 2015 at 11:32:47AM +0300, Dan Carpenter wrote:
<snip>
> >  	}
> > -	rc = cdev_add(&file_cdev, MKDEV(MAJOR(majordev), 0), 1);
> > +	rc = cdev_add(&file_cdev, MKDEV(major, 0), 1);
> 
> This should just be:
> 
> 	rc = cdev_add(&file_cdev, majordev, 1);
> 
> So here is my suggestion:
> 
> [patch 1] delete dead code I mentioned in my previous email.
> 	This deletes "registered" and the (MAJOR(majordev) >= 0) check.

that was initially my first patch.

> 
> [patch 2] pass majordev to visorchipset_file_cleanup()
> 	This lets you delete the "majordev" global.
> 
> [patch 3] small cleanup in visorchipset_file_init()
> 
> -	rc = cdev_add(&file_cdev, MKDEV(MAJOR(majordev), 0), 1);
> +	rc = cdev_add(&file_cdev, majordev, 1);

and i can also include the removal of that global variable in this
3rd patch.
thanks.. after Greg's review i was thinking i understood the code wrong.
but then will this be a v2 or a whole new series?

regards
sudip

> 
> There are several other ways you could break it up but do something like
> that.
> 
> regards,
> dan carpenter
>