From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752265AbbCXJkv (ORCPT <rfc822;w@1wt.eu>);
	Tue, 24 Mar 2015 05:40:51 -0400
Received: from foss.arm.com ([217.140.101.70]:47721 "EHLO foss.arm.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751643AbbCXJku (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 24 Mar 2015 05:40:50 -0400
Date: Tue, 24 Mar 2015 09:41:18 +0000
From: Morten Rasmussen <morten.rasmussen@arm.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: "mingo@redhat.com" <mingo@redhat.com>,
        "vincent.guittot@linaro.org" <vincent.guittot@linaro.org>,
        Dietmar Eggemann <Dietmar.Eggemann@arm.com>,
        "yuyang.du@intel.com" <yuyang.du@intel.com>,
        "preeti@linux.vnet.ibm.com" <preeti@linux.vnet.ibm.com>,
        "mturquette@linaro.org" <mturquette@linaro.org>,
        "nico@linaro.org" <nico@linaro.org>,
        "rjw@rjwysocki.net" <rjw@rjwysocki.net>,
        Juri Lelli <Juri.Lelli@arm.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Russell King <linux@arm.linux.org.uk>
Subject: Re: [RFCv3 PATCH 14/48] arm: Frequency invariant scheduler
 load-tracking support
Message-ID: <20150324094118.GA18994@e105550-lin.cambridge.arm.com>
References: <1423074685-6336-1-git-send-email-morten.rasmussen@arm.com>
 <1423074685-6336-15-git-send-email-morten.rasmussen@arm.com>
 <20150323133944.GG23123@twins.programming.kicks-ass.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150323133944.GG23123@twins.programming.kicks-ass.net>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Mar 23, 2015 at 01:39:44PM +0000, Peter Zijlstra wrote:
> On Wed, Feb 04, 2015 at 06:30:51PM +0000, Morten Rasmussen wrote:
> > +/* cpufreq callback function setting current cpu frequency */
> > +void arch_scale_set_curr_freq(int cpu, unsigned long freq)
> > +{
> > +	atomic_long_set(&per_cpu(cpu_curr_freq, cpu), freq);
> > +}
> > +
> > +/* cpufreq callback function setting max cpu frequency */
> > +void arch_scale_set_max_freq(int cpu, unsigned long freq)
> > +{
> > +	atomic_long_set(&per_cpu(cpu_max_freq, cpu), freq);
> > +}
> > +
> > +unsigned long arch_scale_freq_capacity(struct sched_domain *sd, int cpu)
> > +{
> > +	unsigned long curr = atomic_long_read(&per_cpu(cpu_curr_freq, cpu));
> > +	unsigned long max = atomic_long_read(&per_cpu(cpu_max_freq, cpu));
> > +
> > +	if (!curr || !max)
> > +		return SCHED_CAPACITY_SCALE;
> > +
> > +	return (curr * SCHED_CAPACITY_SCALE) / max;
> > +}
> 
> so I've no idea how many cycles an (integer) division takes on ARM; but
> doesn't it make sense to do this division (once) in
> arch_scale_set_curr_freq() instead of every time we need the result?

It does. In fact I have already prepared that fix for v4. Integer
division is expensive ARM and we call this function a lot.