From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752819AbbCXKb7 (ORCPT <rfc822;w@1wt.eu>);
	Tue, 24 Mar 2015 06:31:59 -0400
Received: from verein.lst.de ([213.95.11.211]:42584 "EHLO newverein.lst.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752254AbbCXKbu (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 24 Mar 2015 06:31:50 -0400
Date: Tue, 24 Mar 2015 11:31:48 +0100
From: Christoph Hellwig <hch@lst.de>
To: Ming Lei <ming.lei@canonical.com>
Cc: Jens Axboe <axboe@fb.com>, linux-kernel@vger.kernel.org,
        Christoph Hellwig <hch@lst.de>, Al Viro <viro@zeniv.linux.org.uk>,
        Maxim Patlasov <mpatlasov@parallels.com>
Subject: Re: [PATCH 3/3] block: loop: use vfs ITER_BVEC to read/write
	backing file
Message-ID: <20150324103148.GC7002@lst.de>
References: <1427012095-4095-1-git-send-email-ming.lei@canonical.com> <1427012095-4095-4-git-send-email-ming.lei@canonical.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1427012095-4095-4-git-send-email-ming.lei@canonical.com>
User-Agent: Mutt/1.5.17 (2007-11-01)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Mar 22, 2015 at 04:14:54PM +0800, Ming Lei wrote:
> Now loop code gets simplified a lot, and becomes more clean.
> 
> Also one extra page copy is avoided for READ in case of none
> transfer.

I really don't like the mess with the wrappers to pretent that read/write
work the same, and the ibvec_rw_data structure doesn't exactly help
readability either.