From: Greg KH <gregkh@linuxfoundation.org>
To: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Cc: aaro.koskinen@iki.fi, nitinkuppelur@gmail.com,
pauldaviesc@gmail.com, br@ahlamon.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: octeon-usb: Made octeon_usb_match const
Date: Tue, 24 Mar 2015 13:31:43 +0100 [thread overview]
Message-ID: <20150324123143.GA20053@kroah.com> (raw)
In-Reply-To: <1425938943-5894-1-git-send-email-mateusz.kulikowski@gmail.com>
On Mon, Mar 09, 2015 at 11:09:03PM +0100, Mateusz Kulikowski wrote:
> An of_device_id should be const (checkpatch.pl warning).
>
> Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
> Acked-by: Aaro Koskinen <aaro.koskinen@iki.fi>
> ---
> drivers/staging/octeon-usb/octeon-hcd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/octeon-usb/octeon-hcd.c b/drivers/staging/octeon-usb/octeon-hcd.c
> index 1daeb31..9591232 100644
> --- a/drivers/staging/octeon-usb/octeon-hcd.c
> +++ b/drivers/staging/octeon-usb/octeon-hcd.c
> @@ -3885,7 +3885,7 @@ static int octeon_usb_remove(struct platform_device *pdev)
> return 0;
> }
>
> -static struct of_device_id octeon_usb_match[] = {
> +static const struct of_device_id octeon_usb_match[] = {
> {
> .compatible = "cavium,octeon-5750-usbc",
> },
Sorry, someone else sent this patch, and I saw their patch first before
yours, and applied it, which was my fault :(
greg k-h
next prev parent reply other threads:[~2015-03-24 12:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-09 22:09 [PATCH] staging: octeon-usb: Made octeon_usb_match const Mateusz Kulikowski
2015-03-09 22:25 ` Aaro Koskinen
2015-03-24 12:31 ` Greg KH [this message]
2015-03-25 15:25 ` Mateusz Kulikowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150324123143.GA20053@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=aaro.koskinen@iki.fi \
--cc=br@ahlamon.org \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mateusz.kulikowski@gmail.com \
--cc=nitinkuppelur@gmail.com \
--cc=pauldaviesc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox