From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752413AbbCXMbx (ORCPT ); Tue, 24 Mar 2015 08:31:53 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:55870 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752197AbbCXMbr (ORCPT ); Tue, 24 Mar 2015 08:31:47 -0400 Date: Tue, 24 Mar 2015 13:31:43 +0100 From: Greg KH To: Mateusz Kulikowski Cc: aaro.koskinen@iki.fi, nitinkuppelur@gmail.com, pauldaviesc@gmail.com, br@ahlamon.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: octeon-usb: Made octeon_usb_match const Message-ID: <20150324123143.GA20053@kroah.com> References: <1425938943-5894-1-git-send-email-mateusz.kulikowski@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1425938943-5894-1-git-send-email-mateusz.kulikowski@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 09, 2015 at 11:09:03PM +0100, Mateusz Kulikowski wrote: > An of_device_id should be const (checkpatch.pl warning). > > Signed-off-by: Mateusz Kulikowski > Acked-by: Aaro Koskinen > --- > drivers/staging/octeon-usb/octeon-hcd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/octeon-usb/octeon-hcd.c b/drivers/staging/octeon-usb/octeon-hcd.c > index 1daeb31..9591232 100644 > --- a/drivers/staging/octeon-usb/octeon-hcd.c > +++ b/drivers/staging/octeon-usb/octeon-hcd.c > @@ -3885,7 +3885,7 @@ static int octeon_usb_remove(struct platform_device *pdev) > return 0; > } > > -static struct of_device_id octeon_usb_match[] = { > +static const struct of_device_id octeon_usb_match[] = { > { > .compatible = "cavium,octeon-5750-usbc", > }, Sorry, someone else sent this patch, and I saw their patch first before yours, and applied it, which was my fault :( greg k-h