* [PATCH] staging: octeon-usb: Made octeon_usb_match const
@ 2015-03-09 22:09 Mateusz Kulikowski
2015-03-09 22:25 ` Aaro Koskinen
2015-03-24 12:31 ` Greg KH
0 siblings, 2 replies; 4+ messages in thread
From: Mateusz Kulikowski @ 2015-03-09 22:09 UTC (permalink / raw)
To: aaro.koskinen
Cc: gregkh, nitinkuppelur, pauldaviesc, br, devel, linux-kernel,
Mateusz Kulikowski
An of_device_id should be const (checkpatch.pl warning).
Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
---
drivers/staging/octeon-usb/octeon-hcd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/octeon-usb/octeon-hcd.c b/drivers/staging/octeon-usb/octeon-hcd.c
index 1daeb31..9591232 100644
--- a/drivers/staging/octeon-usb/octeon-hcd.c
+++ b/drivers/staging/octeon-usb/octeon-hcd.c
@@ -3885,7 +3885,7 @@ static int octeon_usb_remove(struct platform_device *pdev)
return 0;
}
-static struct of_device_id octeon_usb_match[] = {
+static const struct of_device_id octeon_usb_match[] = {
{
.compatible = "cavium,octeon-5750-usbc",
},
--
1.8.4.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] staging: octeon-usb: Made octeon_usb_match const
2015-03-09 22:09 [PATCH] staging: octeon-usb: Made octeon_usb_match const Mateusz Kulikowski
@ 2015-03-09 22:25 ` Aaro Koskinen
2015-03-24 12:31 ` Greg KH
1 sibling, 0 replies; 4+ messages in thread
From: Aaro Koskinen @ 2015-03-09 22:25 UTC (permalink / raw)
To: Mateusz Kulikowski
Cc: gregkh, nitinkuppelur, pauldaviesc, br, devel, linux-kernel
Hi,
On Mon, Mar 09, 2015 at 11:09:03PM +0100, Mateusz Kulikowski wrote:
> An of_device_id should be const (checkpatch.pl warning).
>
> Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Acked-by: Aaro Koskinen <aaro.koskinen@iki.fi>
A.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: octeon-usb: Made octeon_usb_match const
2015-03-09 22:09 [PATCH] staging: octeon-usb: Made octeon_usb_match const Mateusz Kulikowski
2015-03-09 22:25 ` Aaro Koskinen
@ 2015-03-24 12:31 ` Greg KH
2015-03-25 15:25 ` Mateusz Kulikowski
1 sibling, 1 reply; 4+ messages in thread
From: Greg KH @ 2015-03-24 12:31 UTC (permalink / raw)
To: Mateusz Kulikowski
Cc: aaro.koskinen, nitinkuppelur, pauldaviesc, br, devel,
linux-kernel
On Mon, Mar 09, 2015 at 11:09:03PM +0100, Mateusz Kulikowski wrote:
> An of_device_id should be const (checkpatch.pl warning).
>
> Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
> Acked-by: Aaro Koskinen <aaro.koskinen@iki.fi>
> ---
> drivers/staging/octeon-usb/octeon-hcd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/octeon-usb/octeon-hcd.c b/drivers/staging/octeon-usb/octeon-hcd.c
> index 1daeb31..9591232 100644
> --- a/drivers/staging/octeon-usb/octeon-hcd.c
> +++ b/drivers/staging/octeon-usb/octeon-hcd.c
> @@ -3885,7 +3885,7 @@ static int octeon_usb_remove(struct platform_device *pdev)
> return 0;
> }
>
> -static struct of_device_id octeon_usb_match[] = {
> +static const struct of_device_id octeon_usb_match[] = {
> {
> .compatible = "cavium,octeon-5750-usbc",
> },
Sorry, someone else sent this patch, and I saw their patch first before
yours, and applied it, which was my fault :(
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] staging: octeon-usb: Made octeon_usb_match const
2015-03-24 12:31 ` Greg KH
@ 2015-03-25 15:25 ` Mateusz Kulikowski
0 siblings, 0 replies; 4+ messages in thread
From: Mateusz Kulikowski @ 2015-03-25 15:25 UTC (permalink / raw)
To: Greg KH; +Cc: aaro.koskinen, nitinkuppelur, pauldaviesc, br, devel,
linux-kernel
On 24.03.2015 05:31, Greg KH wrote:
> On Mon, Mar 09, 2015 at 11:09:03PM +0100, Mateusz Kulikowski wrote:
(...)
> Sorry, someone else sent this patch, and I saw their patch first before
> yours, and applied it, which was my fault :(
No problem, it was tiny patch, easy to miss.
I'll focus on rtl8192e anyway - I should have hardware soon so bigger
refactorings will be possible.
Mateusz
p.s. Sorry for html garbage in previous mail - shame on me and Android
email client :)
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-03-25 15:25 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-09 22:09 [PATCH] staging: octeon-usb: Made octeon_usb_match const Mateusz Kulikowski
2015-03-09 22:25 ` Aaro Koskinen
2015-03-24 12:31 ` Greg KH
2015-03-25 15:25 ` Mateusz Kulikowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox