From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752397AbbCXMhz (ORCPT <rfc822;w@1wt.eu>);
	Tue, 24 Mar 2015 08:37:55 -0400
Received: from sauhun.de ([89.238.76.85]:45417 "EHLO pokefinder.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752340AbbCXMhw (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 24 Mar 2015 08:37:52 -0400
Date: Tue, 24 Mar 2015 13:38:09 +0100
From: Wolfram Sang <wsa@the-dreams.de>
To: Markus Pargmann <mpa@pengutronix.de>
Cc: Mark Brown <broonie@kernel.org>, Liam Girdwood <lgirdwood@gmail.com>,
        kernel@pengutronix.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] regulator: max8660: Add error message for missing
 regulator data
Message-ID: <20150324123809.GA8766@katana>
References: <1427198883-6577-1-git-send-email-mpa@pengutronix.de>
 <1427198883-6577-2-git-send-email-mpa@pengutronix.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="qDbXVdCdHGoSgWSk"
Content-Disposition: inline
In-Reply-To: <1427198883-6577-2-git-send-email-mpa@pengutronix.de>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


--qDbXVdCdHGoSgWSk
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline


>  	for (i = 0; i < pdata->num_subdevs; i++) {
> -		if (!pdata->subdevs[i].platform_data)
> +		if (!pdata->subdevs[i].platform_data) {
> +			dev_err(dev, "No data for %d regulator\n", i);
>  			return -EINVAL;
> +		}

I'd rather save the string and go for -ENOENT instead. But I don't mind
much...


--qDbXVdCdHGoSgWSk
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBAgAGBQJVEVqxAAoJEBQN5MwUoCm2XjoP/1nqfrhYDguxRGWLZefZEMGK
eTExXEiYW/k4TSITYu+VqzTS+eCijK1ltKPIsXnCb6SV7kR5gRV/fxoQPhIGGdTC
9r4tngXtKXiuwGlnNUpacvhUgdrzzI25hevmpRtBwwuWhf1SiPdlG+YOH22pE8QH
7UQLNMkZhx2d14pkGDOpTcQuRsWOIccB8ssm/8emymwYztJfaKJDjcty43vx5Obw
DSDVDRor9bbY8bZsFdZLLuKFUDpJJjndGs7qOawx4efkZ0H4T5XyLSDOCObr4ylj
WZ3WIuMwc+U8H1dRVEDSkANUU1rsTISzrdm6yahSF/DFeQ7riVAvQAw/VJ6EECuE
Nb5zVqrUF19AlWeLt0T9i3Ytd0UoqMmjM1HhTcswNnVMYCZdU6tpn3hGwfqD/IBh
8YeiME9jsLL4Uwna3G0rpvS4y2hJn7owI6lvygBH8NV9Uzutir5iVyRunzpx3DtM
gsZbcHXT8vlUCWyEKs2s88sYTmsveMWSejaqOTJNo3Vu/jzU/+dSuEwgQRZfDSv8
jQ4IuO4y7v+zPlAk586dT3/nTp2keI5VImGkAj1mXmAGCeYg76y05bRZVWz8zOWU
+iM0wZbMxXL00UiIttIhU7e1f2vvH5anfHm2q8Bpiwnbqn/CgXu2x0ngq2qkuIDX
2d2+tXbo2DECQ+TMsYCl
=G2uM
-----END PGP SIGNATURE-----

--qDbXVdCdHGoSgWSk--