* Re: [PATCH 1/2] octeon-usb:Fix coding style issue with space between function name and opening bracket
[not found] <1427069076-26720-1-git-send-email-xerofoify@gmail.com>
@ 2015-03-23 10:40 ` Dan Carpenter
[not found] ` <8FDBB6BF-55C6-44B5-A645-147F1BEAF388@gmail.com>
0 siblings, 1 reply; 6+ messages in thread
From: Dan Carpenter @ 2015-03-23 10:40 UTC (permalink / raw)
To: Nicholas Krause
Cc: gregkh, devel, aaro.koskinen, pauldaviesc, nitinkuppelur,
linux-kernel, br
On Sun, Mar 22, 2015 at 08:04:35PM -0400, Nicholas Krause wrote:
> Fixes the checkpath.pl error where the opening bracket has a unneeded space between
> it and the function name for a if statement in the marco,VMX_WAIT_FOR_FIELD32.
>
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> ---
> drivers/staging/octeon-usb/octeon-hcd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/octeon-usb/octeon-hcd.c b/drivers/staging/octeon-usb/octeon-hcd.c
> index 1daeb31..0408a12 100644
> --- a/drivers/staging/octeon-usb/octeon-hcd.c
> +++ b/drivers/staging/octeon-usb/octeon-hcd.c
> @@ -412,7 +412,7 @@ struct octeon_hcd {
> type c; \
> while (1) { \
> c.u32 = __cvmx_usb_read_csr32(usb, address); \
> - if (c.s.field op (value)) { \
> + if (c.s.field op(value)) { \
"op" is not a function here. This is macro and top is an operation like
"+" or "*". So checkpatch.pl is wrong.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] octeon-usb:Fix coding style issue with space between function name and opening bracket
[not found] ` <8FDBB6BF-55C6-44B5-A645-147F1BEAF388@gmail.com>
@ 2015-03-23 13:06 ` Dan Carpenter
[not found] ` <B6E63034-68D1-4728-B8C5-71BE94A1CFE3@gmail.com>
0 siblings, 1 reply; 6+ messages in thread
From: Dan Carpenter @ 2015-03-23 13:06 UTC (permalink / raw)
To: Nicholas Krause
Cc: gregkh, devel, aaro.koskinen, pauldaviesc, nitinkuppelur,
linux-kernel, br
On Mon, Mar 23, 2015 at 08:53:19AM -0400, Nicholas Krause wrote:
>
>
> On March 23, 2015 6:40:06 AM EDT, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> >On Sun, Mar 22, 2015 at 08:04:35PM -0400, Nicholas Krause wrote:
> >> Fixes the checkpath.pl error where the opening bracket has a unneeded
> >space between
> >> it and the function name for a if statement in the
> >marco,VMX_WAIT_FOR_FIELD32.
> >>
> >> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> >> ---
> >> drivers/staging/octeon-usb/octeon-hcd.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/staging/octeon-usb/octeon-hcd.c
> >b/drivers/staging/octeon-usb/octeon-hcd.c
> >> index 1daeb31..0408a12 100644
> >> --- a/drivers/staging/octeon-usb/octeon-hcd.c
> >> +++ b/drivers/staging/octeon-usb/octeon-hcd.c
> >> @@ -412,7 +412,7 @@ struct octeon_hcd {
> >> type c; \
> >> while (1) { \
> >> c.u32 = __cvmx_usb_read_csr32(usb, address); \
> >> - if (c.s.field op (value)) { \
> >> + if (c.s.field op(value)) { \
> >
> >"op" is not a function here. This is macro and top is an operation
> >like
> >"+" or "*". So checkpatch.pl is wrong.
> >
> >regards,
> >dan carpenter
> Very well then, I wasn't sure if we did the same spacing style for marcos.
We do but this is a very unusual case.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] octeon-usb:Fix coding style issue with space between function name and opening bracket
[not found] ` <B6E63034-68D1-4728-B8C5-71BE94A1CFE3@gmail.com>
@ 2015-03-24 7:08 ` Dan Carpenter
[not found] ` <15C5DCA5-565D-4E38-B247-4F18FF04930F@gmail.com>
0 siblings, 1 reply; 6+ messages in thread
From: Dan Carpenter @ 2015-03-24 7:08 UTC (permalink / raw)
To: Nicholas Krause
Cc: gregkh, devel, aaro.koskinen, pauldaviesc, nitinkuppelur,
linux-kernel, br
On Mon, Mar 23, 2015 at 05:08:52PM -0400, Nicholas Krause wrote:
>
>
> On March 23, 2015 9:06:26 AM EDT, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> >On Mon, Mar 23, 2015 at 08:53:19AM -0400, Nicholas Krause wrote:
> >>
> >>
> >> On March 23, 2015 6:40:06 AM EDT, Dan Carpenter
> ><dan.carpenter@oracle.com> wrote:
> >> >On Sun, Mar 22, 2015 at 08:04:35PM -0400, Nicholas Krause wrote:
> >> >> Fixes the checkpath.pl error where the opening bracket has a
> >unneeded
> >> >space between
> >> >> it and the function name for a if statement in the
> >> >marco,VMX_WAIT_FOR_FIELD32.
> >> >>
> >> >> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> >> >> ---
> >> >> drivers/staging/octeon-usb/octeon-hcd.c | 2 +-
> >> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >> >>
> >> >> diff --git a/drivers/staging/octeon-usb/octeon-hcd.c
> >> >b/drivers/staging/octeon-usb/octeon-hcd.c
> >> >> index 1daeb31..0408a12 100644
> >> >> --- a/drivers/staging/octeon-usb/octeon-hcd.c
> >> >> +++ b/drivers/staging/octeon-usb/octeon-hcd.c
> >> >> @@ -412,7 +412,7 @@ struct octeon_hcd {
> >> >> type c; \
> >> >> while (1) { \
> >> >> c.u32 = __cvmx_usb_read_csr32(usb, address); \
> >> >> - if (c.s.field op (value)) { \
> >> >> + if (c.s.field op(value)) { \
> >> >
> >> >"op" is not a function here. This is macro and top is an operation
> >> >like
> >> >"+" or "*". So checkpatch.pl is wrong.
> >> >
> >> >regards,
> >> >dan carpenter
> >> Very well then, I wasn't sure if we did the same spacing style for
> >marcos.
> >
> >We do but this is a very unusual case.
> >
> >regards,
> >dan carpenter
> Dan,
> Sorry about that my mistake. In addition, have you looked at my second patch to see if that one is correct.
Yes. That one is fine.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] octeon-usb:Fix coding style issue with space between function name and opening bracket
[not found] ` <15C5DCA5-565D-4E38-B247-4F18FF04930F@gmail.com>
@ 2015-03-24 13:00 ` Dan Carpenter
2015-03-24 13:20 ` Joe Perches
2015-03-24 20:29 ` Aaro Koskinen
1 sibling, 1 reply; 6+ messages in thread
From: Dan Carpenter @ 2015-03-24 13:00 UTC (permalink / raw)
To: Nicholas Krause
Cc: gregkh, devel, aaro.koskinen, pauldaviesc, nitinkuppelur,
linux-kernel, br
On Tue, Mar 24, 2015 at 08:08:16AM -0400, Nicholas Krause wrote:
> Dan,
> Just one more question, is that patch going to be merged or should I resubmit
> it as a series of one patch?
Don't resubmit. Wait for Greg to mail you. It can take a several weeks
because he is busy.
regards,
dan carpetner
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] octeon-usb:Fix coding style issue with space between function name and opening bracket
2015-03-24 13:00 ` Dan Carpenter
@ 2015-03-24 13:20 ` Joe Perches
0 siblings, 0 replies; 6+ messages in thread
From: Joe Perches @ 2015-03-24 13:20 UTC (permalink / raw)
To: Dan Carpenter
Cc: Nicholas Krause, gregkh, devel, aaro.koskinen, pauldaviesc,
nitinkuppelur, linux-kernel, br
On Tue, 2015-03-24 at 16:00 +0300, Dan Carpenter wrote:
> On Tue, Mar 24, 2015 at 08:08:16AM -0400, Nicholas Krause wrote:
> > Just one more question, is that patch going to be merged or should I resubmit
> > it as a series of one patch?
> Don't resubmit. Wait for Greg to mail you. It can take a several weeks
> because he is busy.
What Dan said is certainly true, but if after 4 or
more weeks with no reply, I think it's fine to
resubmit or send a polite "ping" requesting status.
There really no other option as no other feedback
mechanism exists and things can and do get lost in
high-volume process.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] octeon-usb:Fix coding style issue with space between function name and opening bracket
[not found] ` <15C5DCA5-565D-4E38-B247-4F18FF04930F@gmail.com>
2015-03-24 13:00 ` Dan Carpenter
@ 2015-03-24 20:29 ` Aaro Koskinen
1 sibling, 0 replies; 6+ messages in thread
From: Aaro Koskinen @ 2015-03-24 20:29 UTC (permalink / raw)
To: Nicholas Krause
Cc: Dan Carpenter, gregkh, devel, pauldaviesc, nitinkuppelur,
linux-kernel, br
Hi,
On Tue, Mar 24, 2015 at 08:08:16AM -0400, Nicholas Krause wrote:
> On March 24, 2015 3:08:09 AM EDT, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> >On Mon, Mar 23, 2015 at 05:08:52PM -0400, Nicholas Krause wrote:
> >> On March 23, 2015 9:06:26 AM EDT, Dan Carpenter
> ><dan.carpenter@oracle.com> wrote:
> >> >On Mon, Mar 23, 2015 at 08:53:19AM -0400, Nicholas Krause wrote:
> >> >> On March 23, 2015 6:40:06 AM EDT, Dan Carpenter
> >> ><dan.carpenter@oracle.com> wrote:
> >> >> >On Sun, Mar 22, 2015 at 08:04:35PM -0400, Nicholas Krause wrote:
> >> >> >> Fixes the checkpath.pl error where the opening bracket has a
> >> >unneeded
> >> >> >space between
> >> >> >> it and the function name for a if statement in the
> >> >> >marco,VMX_WAIT_FOR_FIELD32.
> >> >> >>
> >> >> >> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> >> >> >> ---
> >> >> >> drivers/staging/octeon-usb/octeon-hcd.c | 2 +-
> >> >> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >> >> >>
> >> >> >> diff --git a/drivers/staging/octeon-usb/octeon-hcd.c
> >> >> >b/drivers/staging/octeon-usb/octeon-hcd.c
> >> >> >> index 1daeb31..0408a12 100644
> >> >> >> --- a/drivers/staging/octeon-usb/octeon-hcd.c
> >> >> >> +++ b/drivers/staging/octeon-usb/octeon-hcd.c
> >> >> >> @@ -412,7 +412,7 @@ struct octeon_hcd {
> >> >> >> type c; \
> >> >> >> while (1) { \
> >> >> >> c.u32 = __cvmx_usb_read_csr32(usb, address); \
> >> >> >> - if (c.s.field op (value)) { \
> >> >> >> + if (c.s.field op(value)) { \
> >> >> >
> >> >> >"op" is not a function here. This is macro and top is an
> >operation
> >> >> >like
> >> >> >"+" or "*". So checkpatch.pl is wrong.
> >> >> >
> >> >> >regards,
> >> >> >dan carpenter
> >> >> Very well then, I wasn't sure if we did the same spacing style
> >for
> >> >marcos.
> >> >
> >> >We do but this is a very unusual case.
> >> >
> >> >regards,
> >> >dan carpenter
> >> Dan,
> >> Sorry about that my mistake. In addition, have you looked at my
> >second patch to see if that one is correct.
> >
> >Yes. That one is fine.
> >
> >regards,
> >dan carpenter
> Dan,
> Just one more question, is that patch going to be merged or should I resubmit
> it as a series of one patch?
Someone else already sent the same patch that got applied:
https://git.kernel.org/cgit/linux/kernel/git/gregkh/staging.git/commit/drivers/staging/octeon-usb?h=staging-testing&id=877945759df5ff6e7fb434cb5b6cddb606c2f66f
A.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-03-24 20:29 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1427069076-26720-1-git-send-email-xerofoify@gmail.com>
2015-03-23 10:40 ` [PATCH 1/2] octeon-usb:Fix coding style issue with space between function name and opening bracket Dan Carpenter
[not found] ` <8FDBB6BF-55C6-44B5-A645-147F1BEAF388@gmail.com>
2015-03-23 13:06 ` Dan Carpenter
[not found] ` <B6E63034-68D1-4728-B8C5-71BE94A1CFE3@gmail.com>
2015-03-24 7:08 ` Dan Carpenter
[not found] ` <15C5DCA5-565D-4E38-B247-4F18FF04930F@gmail.com>
2015-03-24 13:00 ` Dan Carpenter
2015-03-24 13:20 ` Joe Perches
2015-03-24 20:29 ` Aaro Koskinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).