From: Jeff Epler <jepler@unpythonic.net>
To: Javi Merino <javi.merino@arm.com>
Cc: akpm@linux-foundation.org, intel-gfx@lists.freedesktop.org,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
emil.l.velikov@gmail.com, daniel@ffwll.ch,
Jani Nikula <jani.nikula@linux.intel.com>,
David Airlie <airlied@linux.ie>,
Guenter Roeck <linux@roeck-us.net>
Subject: Re: [PATCH v2 1/4] kernel.h: Implement DIV_ROUND_CLOSEST_ULL
Date: Tue, 24 Mar 2015 09:29:27 -0500 [thread overview]
Message-ID: <20150324142926.GF17049@unpythonic.net> (raw)
In-Reply-To: <1427205825-5444-2-git-send-email-javi.merino@arm.com>
[for just patch 1/4; I didn't look as closely at the others]
Reviewed-by: Jeff Epler <jepler@unpythonic.net>
...with one half of a caveat (rounded up?): Like most or all of the
originals, and like DIV_ROUND_CLOSEST just above it in kernel.h, the new
code gives an incorrect answer if the temporary overflows at
+ unsigned long long _tmp = (x) + (__d) / 2;
As a doc improvement a remark could be added to a number of these
functions, but there's little reason for that to be part of this series.
Jeff
next prev parent reply other threads:[~2015-03-24 14:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-24 14:03 [PATCH v2 0/4] Consolidate DIV_ROUND_CLOSEST_ULL() Javi Merino
2015-03-24 14:03 ` [PATCH v2 1/4] kernel.h: Implement DIV_ROUND_CLOSEST_ULL Javi Merino
2015-03-24 14:29 ` Jeff Epler [this message]
2015-03-24 14:03 ` [PATCH v2 2/4] clk: bcm/kona: use DIV_ROUND_CLOSEST_ULL() Javi Merino
2015-03-24 18:03 ` Alex Elder
2015-03-24 14:03 ` [PATCH v2 3/4] cpuidle: menu: " Javi Merino
2015-03-24 20:22 ` Rafael J. Wysocki
2015-03-25 11:40 ` Rafael J. Wysocki
2015-03-24 14:03 ` [PATCH v2 4/4] media: cxd2820r: " Javi Merino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150324142926.GF17049@unpythonic.net \
--to=jepler@unpythonic.net \
--cc=airlied@linux.ie \
--cc=akpm@linux-foundation.org \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=emil.l.velikov@gmail.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=javi.merino@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox