From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753151AbbCXPmn (ORCPT <rfc822;w@1wt.eu>);
	Tue, 24 Mar 2015 11:42:43 -0400
Received: from mail-qg0-f52.google.com ([209.85.192.52]:32874 "EHLO
	mail-qg0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753062AbbCXPmd (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 24 Mar 2015 11:42:33 -0400
Date: Tue, 24 Mar 2015 11:41:59 -0400
From: Tejun Heo <tj@kernel.org>
To: Lai Jiangshan <laijs@cn.fujitsu.com>
Cc: linux-kernel@vger.kernel.org, Frederic Weisbecker <fweisbec@gmail.com>,
        Christoph Lameter <cl@linux.com>, Kevin Hilman <khilman@linaro.org>,
        Mike Galbraith <bitbucket@online.de>,
        "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
        Viresh Kumar <viresh.kumar@linaro.org>
Subject: Re: [PATCH 1/4 V5] workqueue: Reorder sysfs code
Message-ID: <20150324154159.GG3880@htj.duckdns.org>
References: <1426136412-7594-1-git-send-email-laijs@cn.fujitsu.com>
 <1426653617-3240-1-git-send-email-laijs@cn.fujitsu.com>
 <1426653617-3240-2-git-send-email-laijs@cn.fujitsu.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1426653617-3240-2-git-send-email-laijs@cn.fujitsu.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello,

On Wed, Mar 18, 2015 at 12:40:14PM +0800, Lai Jiangshan wrote:
> @@ -4029,6 +3712,323 @@ out_unlock:
>  	put_pwq_unlocked(old_pwq);
>  }
>  
> +#ifdef CONFIG_SYSFS
...
> +#else	/* CONFIG_SYSFS */
> +static void workqueue_sysfs_unregister(struct workqueue_struct *wq)	{ }
> +#endif	/* CONFIG_SYSFS */
> +
>  static int alloc_and_link_pwqs(struct workqueue_struct *wq)
>  {
>  	bool highpri = wq->flags & WQ_HIGHPRI;

Why here?  It's still in the middle of core logic implementation.  Why
not move it further down so that it's either before or after the
hotplug code?

Thanks.

-- 
tejun