From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753508AbbCXQF1 (ORCPT ); Tue, 24 Mar 2015 12:05:27 -0400 Received: from mail-ie0-f175.google.com ([209.85.223.175]:32813 "EHLO mail-ie0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752335AbbCXQFX (ORCPT ); Tue, 24 Mar 2015 12:05:23 -0400 Date: Tue, 24 Mar 2015 09:05:18 -0700 From: Dmitry Torokhov To: Gerd Hoffmann Cc: "Michael S. Tsirkin" , virtio-dev@lists.oasis-open.org, virtualization@lists.linux-foundation.org, David Herrmann , Rusty Russell , open list , "open list:ABI/API" Subject: Re: [virtio-dev] Re: [PATCH v3] Add virtio-input driver. Message-ID: <20150324160518.GA34117@dtor-ws> References: <1427182321-19451-1-git-send-email-kraxel@redhat.com> <20150324105829-mutt-send-email-mst@redhat.com> <1427197581.18768.16.camel@nilsson.home.kraxel.org> <20150324135908-mutt-send-email-mst@redhat.com> <1427204244.18768.21.camel@nilsson.home.kraxel.org> <20150324143839-mutt-send-email-mst@redhat.com> <1427210714.18768.23.camel@nilsson.home.kraxel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1427210714.18768.23.camel@nilsson.home.kraxel.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 24, 2015 at 04:25:14PM +0100, Gerd Hoffmann wrote: > On Di, 2015-03-24 at 15:14 +0100, Michael S. Tsirkin wrote: > > On Tue, Mar 24, 2015 at 02:37:24PM +0100, Gerd Hoffmann wrote: > > > Hi, > > > > > > > > input layer checks it and ignores events not supported (according to the > > > > > support bitmaps). > > > > > > > > Right but support bitmaps come from host too, no? > > > > > > Yes, but the driver will not set invalid bits (bitcount argument for the > > > virtinput_cfg_bits() function is the number of valid bits of the > > > specific bitmap). > > > > > > cheers, > > > Gerd > > > > > > > > > > > > > Question: does linux ever get such events from userspace > > as opposed to sending them to userspace? > > Yes, it's possible using the userspace input driver > (CONFIG_INPUT_UINPUT) No, not through uinput (as from kernel POV uinput is also a driver), but users can write into evdev. Sending unknown codes is OK: events of unknown type will be dropped by the input core, unknown event codes will be passed on; users not recognizing event code should simply ignore it. Thanks. -- Dmitry