From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932093AbbCXQis (ORCPT ); Tue, 24 Mar 2015 12:38:48 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:47199 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752754AbbCXQin (ORCPT ); Tue, 24 Mar 2015 12:38:43 -0400 Date: Tue, 24 Mar 2015 11:37:43 -0500 From: Felipe Balbi To: Sudeep Holla CC: Laurent Pinchart , Felipe Balbi , "linux-usb@vger.kernel.org" , Dan Carpenter , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] usb: isp1760: fix spin unlock in the error path of isp1760_udc_start Message-ID: <20150324163743.GE31024@saruman.tx.rr.com> Reply-To: References: <1426851737-24999-1-git-send-email-sudeep.holla@arm.com> <14712088.dyzVQIQYao@avalon> <550C2E5C.70708@arm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="kA1LkgxZ0NN7Mz3A" Content-Disposition: inline In-Reply-To: <550C2E5C.70708@arm.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --kA1LkgxZ0NN7Mz3A Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Mar 20, 2015 at 02:27:40PM +0000, Sudeep Holla wrote: > Hi Laurent, >=20 > On 20/03/15 14:20, Laurent Pinchart wrote: > >Hi Sudeep, > > > >Thank you for the patch. > > > >On Friday 20 March 2015 11:42:17 Sudeep Holla wrote: > >>Commit a124820de5fd ("usb: isp1760: fix possible deadlock in > >>isp1760_udc_irq") replaced spin_{un,}lock with > >>spin_{un,}lock_irq{save,restore}. However it missed an error path resul= ting > >>in the smatch warning as below: > >> > >>drivers/usb/isp1760/isp1760-udc.c:1230 isp1760_udc_start() warn: > >>inconsistent returns 'irqsave:flags'. Locked on: line 1207 > >>Unlocked on: line 1199 > >> > >>This patch fixes the spin unlock in the error path in isp1760_udc_start > >>thereby removing the smatch warning mentioned above. > >> > >>Reported-by: Dan Carpenter > >>Cc: Laurent Pinchart > >>Cc: Felipe Balbi > >>Signed-off-by: Sudeep Holla > > > >Acked-by: Laurent Pinchart > > >=20 > Thanks >=20 > >>--- > >> drivers/usb/isp1760/isp1760-udc.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >>Hi Laurent, Felipe, > >> > >>I am extremely sorry for missing this in my original patch. > > > >I hope you will be ashamed for the 7 generations to come for this totally > >unacceptable low quality standard. > > >=20 > Yes ;) shameful indeed, doesn't build ;-) drivers/usb/isp1760/isp1760-udc.c:1205:52: error: undefined identifier 'fla= gs' drivers/usb/isp1760/isp1760-udc.c: In function =E2=80=98isp1760_udc_start= =E2=80=99: drivers/usb/isp1760/isp1760-udc.c:1205:38: error: =E2=80=98flags=E2=80=99 u= ndeclared (first use in this function) spin_unlock_irqrestore(&udc->lock, flags); ^ drivers/usb/isp1760/isp1760-udc.c:1205:38: note: each undeclared identifier= is reported only once for each function it appears in make[2]: *** [drivers/usb/isp1760/isp1760-udc.o] Error 1 make[1]: *** [drivers/usb/isp1760] Error 2 make[1]: *** Waiting for unfinished jobs.... make: *** [drivers/usb/] Error 2 --=20 balbi --kA1LkgxZ0NN7Mz3A Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVEZLXAAoJEIaOsuA1yqRELJwP/08D/tkbiIdW/EweI1laNdRS u/6IWqh0RfKdKqx2ryhzY1BC4604I0vvaZi5BquU+ilO/ukCebttTnPLLZytKtTQ fni3a1Nb7CTj3uj4ihENmj/wvk3iOd0Y0D6yMew7UzG2qMWPdckcGerO9vGc+UY4 TaW/GT9XCt4d8Les9LSVkSN9NAt7nihBhlCcjCVsQBGMaM1gOR23+zC1DMPAMF1O XNldD2GiqGgCULpDjqBMMmEXW3LNnJgujX3LZUG4wquDgELdH+e7N6X9tDrXG1OI mYCxQXzt/BiaIzxYh22amo4qqVrPW8W1W2nswjv0bhLV4ZPr7owwJtgF9OHrbYtT y8rOgnyYhhz0aCzqDmS+AzSEuTwgIWtafJkm+gJEe4+aJD+M856PeblNlP4zhHnZ gPdPEYsUBTqjqGQkE2RP1qRx+flA4N3zpKlK9VO7PFImN1qqXp8ciT3Br9LodUy7 8YytOkCLJKBB1crZ/H9xrni14AFZvd+FB4eqQgpjES0YCWaqg99NHmlLvLrPo8jW zmyucAZ2ObtDash+GuRbbgaxSq3yv1R7W8EQGt3FRVyd0uvhFgsRLHbWB7qY/n6r ymOE9NHy479UQztMienDR5ycsc4ERd8lPmkN7NPOFVmW0ivu1JLjUiD0MkVmtFb3 doSlg75hPt84LjR9VfuG =oudK -----END PGP SIGNATURE----- --kA1LkgxZ0NN7Mz3A--