From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932283AbbCXQjk (ORCPT ); Tue, 24 Mar 2015 12:39:40 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:47551 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752752AbbCXQjj (ORCPT ); Tue, 24 Mar 2015 12:39:39 -0400 Date: Tue, 24 Mar 2015 11:38:40 -0500 From: Felipe Balbi To: Felipe Balbi CC: Sudeep Holla , Laurent Pinchart , "linux-usb@vger.kernel.org" , Dan Carpenter , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] usb: isp1760: fix spin unlock in the error path of isp1760_udc_start Message-ID: <20150324163840.GF31024@saruman.tx.rr.com> Reply-To: References: <1426851737-24999-1-git-send-email-sudeep.holla@arm.com> <14712088.dyzVQIQYao@avalon> <550C2E5C.70708@arm.com> <20150324163743.GE31024@saruman.tx.rr.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="nYySOmuH/HDX6pKp" Content-Disposition: inline In-Reply-To: <20150324163743.GE31024@saruman.tx.rr.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --nYySOmuH/HDX6pKp Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Mar 24, 2015 at 11:37:43AM -0500, Felipe Balbi wrote: > On Fri, Mar 20, 2015 at 02:27:40PM +0000, Sudeep Holla wrote: > > Hi Laurent, > >=20 > > On 20/03/15 14:20, Laurent Pinchart wrote: > > >Hi Sudeep, > > > > > >Thank you for the patch. > > > > > >On Friday 20 March 2015 11:42:17 Sudeep Holla wrote: > > >>Commit a124820de5fd ("usb: isp1760: fix possible deadlock in > > >>isp1760_udc_irq") replaced spin_{un,}lock with > > >>spin_{un,}lock_irq{save,restore}. However it missed an error path res= ulting > > >>in the smatch warning as below: > > >> > > >>drivers/usb/isp1760/isp1760-udc.c:1230 isp1760_udc_start() warn: > > >>inconsistent returns 'irqsave:flags'. Locked on: line 1207 > > >>Unlocked on: line 1199 > > >> > > >>This patch fixes the spin unlock in the error path in isp1760_udc_sta= rt > > >>thereby removing the smatch warning mentioned above. > > >> > > >>Reported-by: Dan Carpenter > > >>Cc: Laurent Pinchart > > >>Cc: Felipe Balbi > > >>Signed-off-by: Sudeep Holla > > > > > >Acked-by: Laurent Pinchart > > > > >=20 > > Thanks > >=20 > > >>--- > > >> drivers/usb/isp1760/isp1760-udc.c | 2 +- > > >> 1 file changed, 1 insertion(+), 1 deletion(-) > > >> > > >>Hi Laurent, Felipe, > > >> > > >>I am extremely sorry for missing this in my original patch. > > > > > >I hope you will be ashamed for the 7 generations to come for this tota= lly > > >unacceptable low quality standard. > > > > >=20 > > Yes ;) >=20 > shameful indeed, doesn't build ;-) >=20 > drivers/usb/isp1760/isp1760-udc.c:1205:52: error: undefined identifier 'f= lags' > drivers/usb/isp1760/isp1760-udc.c: In function =E2=80=98isp1760_udc_start= =E2=80=99: > drivers/usb/isp1760/isp1760-udc.c:1205:38: error: =E2=80=98flags=E2=80=99= undeclared (first use in this function) > spin_unlock_irqrestore(&udc->lock, flags); > ^ > drivers/usb/isp1760/isp1760-udc.c:1205:38: note: each undeclared identifi= er is reported only once for each function it appears in > make[2]: *** [drivers/usb/isp1760/isp1760-udc.o] Error 1 > make[1]: *** [drivers/usb/isp1760] Error 2 > make[1]: *** Waiting for unfinished jobs.... > make: *** [drivers/usb/] Error 2 oh, nevermind, it depends on a previous fix :-) --=20 balbi --nYySOmuH/HDX6pKp Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVEZMQAAoJEIaOsuA1yqREnl8P/j4ee62cYIr0PXxC7Uoa6dJ6 yE3GT/R50GKVxxtmNxp4NafCQUmhbrBxlu84LigeBSoTyblmntlijIVG1iMkgkwO ORs/chv/604e6vUxuJHvpKVrZJ7lErA1m3OcwZ8sG6oWnjGlPdN2CgXYiu6fCHDn WwOBQnUpj3cIbwaDefoMD4Erv2w2G+Skz2nqxITq+IgYVIZuK4bSJqMUrg076tqF tahd1n9LiCTGOtmcvQsDCiXGUu+fqyfW03ACFZ8yLK0MR3VOTwIwbyds/uYc9t8J XlXzpWd1KiWuwyD4F6cJuiXGac+ZUup6khDU35N8vUUX0ndFwlwxqsM7WrKX752r Nm+aSVR2z2sXOijrjZNicwzNrZQGjaw8RO7W5AmbeH6duxzXUJwIWCDjMP16U7K4 HaaS368TK70h4AZeqUGwSkvJLOb57C+/Dgl6SpKvAV89rPCTQlJOEgVWoYzGJQfV CFkMyfAbqQvnBChx9LBxvIFD4/p5PUuxxvRGKbCzMeL1y4k6BOP18EoVhIjhXYmb 6YAg+vZDgH50goWy7qNS3mui+xoHbU7viChdK93ACQLd0Pz0GLqabV+YKFtsc/3x b30z/0dnjqt8wTkSFgdW1Xpf0NAoLxGygyLtAQj4pMg4PB1Ga8l54EriLSJv1zJD L7CXAbhzox8wtPTvnT/9 =IvVM -----END PGP SIGNATURE----- --nYySOmuH/HDX6pKp--