From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753981AbbCXQvr (ORCPT ); Tue, 24 Mar 2015 12:51:47 -0400 Received: from opensource.wolfsonmicro.com ([80.75.67.52]:48753 "EHLO opensource.wolfsonmicro.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752776AbbCXQvq (ORCPT ); Tue, 24 Mar 2015 12:51:46 -0400 Date: Tue, 24 Mar 2015 16:51:44 +0000 From: Charles Keepax To: Mark Brown Cc: lee.jones@linaro.org, sameo@linux.intel.com, patches@opensource.wolfsonmicro.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/5] mfd: arizona: Add missing gpio_free in arizona_dev_exit Message-ID: <20150324165144.GJ23705@opensource.wolfsonmicro.com> References: <1427209192-12795-1-git-send-email-ckeepax@opensource.wolfsonmicro.com> <1427209192-12795-2-git-send-email-ckeepax@opensource.wolfsonmicro.com> <20150324160642.GE17265@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150324160642.GE17265@sirena.org.uk> User-Agent: Mutt/1.5.17+20080114 (2008-01-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 24, 2015 at 09:06:43AM -0700, Mark Brown wrote: > On Tue, Mar 24, 2015 at 02:59:48PM +0000, Charles Keepax wrote: > > > - if (arizona->pdata.reset) > > + if (arizona->pdata.reset) { > > gpio_set_value_cansleep(arizona->pdata.reset, 0); > > + gpio_free(arizona->pdata.reset); > > + } > > Or acquire the GPIO with devm_ and avoid having to explicitly free it at > all? Ooops... yeah will respin for that. Thanks, Charles