From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754797AbbCXS4W (ORCPT ); Tue, 24 Mar 2015 14:56:22 -0400 Received: from mail-ie0-f173.google.com ([209.85.223.173]:34706 "EHLO mail-ie0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754131AbbCXS4T (ORCPT ); Tue, 24 Mar 2015 14:56:19 -0400 Date: Tue, 24 Mar 2015 11:56:14 -0700 From: Dmitry Torokhov To: Maxime Ripard Cc: Lothar =?iso-8859-1?Q?Wa=DFmann?= , Henrik Rydberg , linux-input@vger.kernel.org, Markus Pargmann , linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 0/4] input: ft5x06: Fix userspace reported maximum value Message-ID: <20150324185614.GC27693@dtor-ws> References: <1425390646-31196-1-git-send-email-maxime.ripard@free-electrons.com> <20150324001002.GJ15676@lukather> <20150324164722.GA11352@dtor-ws> <20150324184520.GE4951@lukather> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150324184520.GE4951@lukather> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 24, 2015 at 11:45:20AM -0700, Maxime Ripard wrote: > On Tue, Mar 24, 2015 at 09:47:22AM -0700, Dmitry Torokhov wrote: > > On Mon, Mar 23, 2015 at 05:10:02PM -0700, Maxime Ripard wrote: > > > Hi Lothar, Dmitry, > > > > > > On Tue, Mar 03, 2015 at 02:50:42PM +0100, Maxime Ripard wrote: > > > > Hi, > > > > > > > > The current ft5x06 reports to the user-space that its maximum > > > > coordinates are, on both X and Y, way higher than what could be > > > > actually usable on the screen (in my case, 5759x1151 instead of > > > > 480x800). > > > > > > > > This causes trouble on some userspace stacks that then try to re-scale > > > > these coordinates back to the framebuffer resolution, like QT does. > > > > > > > > Use the of_touchscreen code to find the real touchscreen limits in the > > > > DT case, and report that to the userspace. > > > > > > Do you have any comments on that? > > > > Yes, I'll apply it, although if you could supply the updated patch > > description for #1 that would be great. The current one seems from the > > old version and is no longer accurate. > > > > Thanks. > > You're right. > > Would something like: > > """ > input: touchscreen: of: Rework the DT parsing function > > The DT parsing function currently duplicates a lot of the code to > parse the touchscreen DT properties. > > In order to ease further additions to this parsing routine, rework it > slightly to create new helper functions. > > Signed-off-by: Maxime Ripard > """ > > be good enough? Yep, thanks, I'll update the description, consider applied. Thanks. -- Dmitry