From: Ingo Molnar <mingo@kernel.org>
To: Andy Lutomirski <luto@amacapital.net>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
Brad Spengler <spender@grsecurity.net>,
Linus Torvalds <torvalds@linux-foundation.org>,
Borislav Petkov <bp@alien8.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Andrew Lutomirski <luto@kernel.org>,
Denys Vlasenko <dvlasenk@redhat.com>,
"linux-tip-commits@vger.kernel.org"
<linux-tip-commits@vger.kernel.org>
Subject: Re: [tip:x86/asm] x86/asm/entry: Add user_mode_ignore_vm86()
Date: Tue, 24 Mar 2015 20:44:02 +0100 [thread overview]
Message-ID: <20150324194402.GA27598@gmail.com> (raw)
In-Reply-To: <CALCETrWZfcRhHogkTC--9aRGOuXuOYuvNdQfrCj0cK3+eNW4jA@mail.gmail.com>
* Andy Lutomirski <luto@amacapital.net> wrote:
> On Mon, Mar 23, 2015 at 5:26 AM, tip-bot for Andy Lutomirski
> <tipbot@zytor.com> wrote:
> > Commit-ID: a67e7277d01ccfd39b0db5a198c2643cc19dd79c
> > Gitweb: http://git.kernel.org/tip/a67e7277d01ccfd39b0db5a198c2643cc19dd79c
> > Author: Andy Lutomirski <luto@kernel.org>
> > AuthorDate: Wed, 18 Mar 2015 18:33:29 -0700
> > Committer: Ingo Molnar <mingo@kernel.org>
> > CommitDate: Mon, 23 Mar 2015 11:13:36 +0100
> >
> > x86/asm/entry: Add user_mode_ignore_vm86()
> >
> > user_mode() is dangerous and user_mode_vm() has a confusing name.
> >
> > Add user_mode_ignore_vm86() (equivalent to current user_mode()).
> > We'll change the small number of legitimate users of user_mode()
> > to user_mode_ignore_vm86().
> >
> > Inspired by grsec, although this works rather differently.
>
> Ingo, does this mean that you changed your mind or do you still want
> a patch to delete user_mode_ignore_vm86 and just use user_mode
> everywhere instead?
Would be still nice to have it as an add on patch, if you agree with
my arguments.
I picked up your series as-is because it's correct and because it
already improves things a lot in this area.
Thanks,
Ingo
next prev parent reply other threads:[~2015-03-24 19:44 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-19 1:33 [PATCH 0/9] user_mode_vm removal and associated cleanups Andy Lutomirski
2015-03-19 1:33 ` [PATCH 1/9] x86, fault: Use TASK_SIZE_MAX in is_prefetch Andy Lutomirski
2015-03-23 12:20 ` [tip:x86/asm] x86/mm/fault: Use TASK_SIZE_MAX in is_prefetch() tip-bot for Andy Lutomirski
2015-03-19 1:33 ` [PATCH 2/9] x86, perf: Fix incorrect TIF_IA32 check in code_segment_base Andy Lutomirski
2015-03-23 12:20 ` [tip:x86/asm] x86/asm/entry, perf: Fix incorrect TIF_IA32 check in code_segment_base() tip-bot for Andy Lutomirski
2015-03-19 1:33 ` [PATCH 3/9] x86: Add user_mode_ignore_vm86 Andy Lutomirski
2015-03-23 12:26 ` [tip:x86/asm] x86/asm/entry: Add user_mode_ignore_vm86() tip-bot for Andy Lutomirski
2015-03-23 19:38 ` Andy Lutomirski
2015-03-24 19:44 ` Ingo Molnar [this message]
2015-03-24 19:46 ` Andy Lutomirski
2015-03-27 13:48 ` Denys Vlasenko
2015-03-29 7:08 ` Ingo Molnar
2015-03-29 9:02 ` [PATCH] x86/asm/entry: Remove user_mode_ignore_vm86() Ingo Molnar
2015-03-29 12:13 ` Borislav Petkov
2015-03-29 13:24 ` Andy Lutomirski
2015-03-31 12:39 ` [tip:x86/asm] " tip-bot for Ingo Molnar
2015-03-29 11:55 ` [tip:x86/asm] x86/asm/entry: Add user_mode_ignore_vm86() Borislav Petkov
2015-03-29 20:51 ` Denys Vlasenko
2015-03-19 1:33 ` [PATCH 4/9] x86, perf: Explicitly optimize vm86 handling in code_segment_base Andy Lutomirski
2015-03-23 12:26 ` [tip:x86/asm] x86/asm/entry, perf: Explicitly optimize vm86 handling in code_segment_base() tip-bot for Andy Lutomirski
2015-03-19 1:33 ` [PATCH 5/9] x86, traps: Use user_mode_ignore_vm86 where appropriate Andy Lutomirski
2015-03-23 12:27 ` [tip:x86/asm] x86/asm/entry: Use user_mode_ignore_vm86() " tip-bot for Andy Lutomirski
2015-03-19 1:33 ` [PATCH 6/9] x86: Make user_mode work correctly if regs came from vm86 mode Andy Lutomirski
2015-03-23 12:27 ` [tip:x86/asm] x86/asm/entry: Make user_mode() work correctly if regs came from VM86 mode tip-bot for Andy Lutomirski
2015-03-19 1:33 ` [PATCH 7/9] x86, treewide: s/user_mode_vm/user_mode/g Andy Lutomirski
2015-03-23 12:27 ` [tip:x86/asm] x86/asm/entry: Change all 'user_mode_vm()' calls to 'user_mode()' tip-bot for Andy Lutomirski
2015-03-19 1:33 ` [PATCH 8/9] x86: Remove user_mode_vm Andy Lutomirski
2015-03-23 12:28 ` [tip:x86/asm] x86/asm/entry: Remove user_mode_vm() tip-bot for Andy Lutomirski
2015-03-19 1:33 ` [PATCH 9/9] x86, traps: Replace some open-coded vm86 checks with v8086_mode Andy Lutomirski
2015-03-23 12:28 ` [tip:x86/asm] x86/asm/entry: Replace some open-coded VM86 checks with v8086_mode() checks tip-bot for Andy Lutomirski
2015-03-19 6:33 ` [PATCH 0/9] user_mode_vm removal and associated cleanups Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150324194402.GA27598@gmail.com \
--to=mingo@kernel.org \
--cc=bp@alien8.de \
--cc=dvlasenk@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=luto@kernel.org \
--cc=spender@grsecurity.net \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).