linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Don Zickus <dzickus@redhat.com>
To: David Ahern <dsahern@gmail.com>
Cc: acme@kernel.org, linux-kernel@vger.kernel.org,
	Jiri Olsa <jolsa@redhat.com>,
	jmario@redhat.com
Subject: Re: [PATCH] perf tool: Fix ppid for synthesized fork events
Date: Tue, 24 Mar 2015 16:10:20 -0400	[thread overview]
Message-ID: <20150324201020.GH199787@redhat.com> (raw)
In-Reply-To: <550B3A66.2030902@gmail.com>

On Thu, Mar 19, 2015 at 03:06:46PM -0600, David Ahern wrote:
> On 3/19/15 2:56 PM, Don Zickus wrote:
> >On Thu, Mar 19, 2015 at 11:41:15AM -0600, David Ahern wrote:
> >>>363b785f38 added synthesized fork events and set a thread's parent id
> >>>to itself. Since we are already processing/proc/<pid>/status the ppid
> >>>can be determined properly. Make it so.
> >Thanks David.  My tester, Joe, is currently running other tests and then is
> >out until Tuesday.  I will try to provide test feedback by Tuesday or
> >Wednesday if it can wait.
> 
> ok. thanks for the heads up.

Hmm, preliminary tests, show a significant slow down in perf record and perf
report.  I would be against this patch for now.  We will dig into what the
problem is.

Joe is running a specjbb bench with lots of threads in the background and
running:

perf mem record -a -e 'cpu/mem-loads,ldlat=50/pp' -e 'cpu/mem-stores/pp' sleep 10


multiple times to get an average.  And also

perf mem report --stdio

to get that timing average too..

He does this with and without the patch.  The difference is usually over 50%
extra time with the patch for both the record timings and report timings. :-(

Cheers,
Don

  parent reply	other threads:[~2015-03-24 20:10 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-19 17:41 [PATCH] perf tool: Fix ppid for synthesized fork events David Ahern
2015-03-19 20:56 ` Don Zickus
2015-03-19 21:06   ` David Ahern
2015-03-20 14:01     ` Arnaldo Carvalho de Melo
2015-03-24 20:10     ` Don Zickus [this message]
2015-03-24 21:12       ` David Ahern
2015-03-25 12:22         ` Joe Mario
2015-03-25 13:24           ` Arnaldo Carvalho de Melo
2015-03-25 15:03             ` David Ahern
2015-03-25 19:20               ` Don Zickus
2015-03-25 16:57           ` David Ahern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150324201020.GH199787@redhat.com \
    --to=dzickus@redhat.com \
    --cc=acme@kernel.org \
    --cc=dsahern@gmail.com \
    --cc=jmario@redhat.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).