public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Niranjan Dighe <niranjan.dighe@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
	charrer@alacritech.com, liodot@gmail.com,
	linux-kernel@vger.kernel.org
Subject: Re: Staging: slicoss: Fix checkpatch.pl issues
Date: Tue, 24 Mar 2015 23:14:29 +0300	[thread overview]
Message-ID: <20150324201429.GV10964@mwanda> (raw)
In-Reply-To: <1427224146-7926-1-git-send-email-niranjan.dighe@gmail.com>

On Wed, Mar 25, 2015 at 12:39:06AM +0530, Niranjan Dighe wrote:
> The following files had coding style issues that I tried to address.
> It was mostly about lines spanning more than 80 characters.
> 
> Signed-off-by: Niranjan Dighe <niranjan.dighe@gmail.com>
> 
> diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c
> index 3104cb0..2161bdb 100644
> --- a/drivers/staging/slicoss/slicoss.c
> +++ b/drivers/staging/slicoss/slicoss.c
> @@ -98,7 +98,8 @@
>  #include "slic.h"
>  
>  static uint slic_first_init = 1;
> -static char *slic_banner = "Alacritech SLIC Technology(tm) Server and Storage Accelerator (Non-Accelerated)";
> +static char *slic_banner = "Alacritech SLIC Technology(tm) Server "
> +			"and Storage Accelerator (Non-Accelerated)";

Just leave it.  The original is better for grepping.

>  
>  static char *slic_proc_version = "2.0.351  2006/07/14 12:26:00";
>  
> @@ -755,10 +756,10 @@ static bool slic_mac_filter(struct adapter *adapter,
>  
>  			while (mcaddr) {
>  				if (ether_addr_equal(mcaddr->address,
> -						     ether_frame->ether_dhost)) {
> -					adapter->rcv_multicasts++;
> -					netdev->stats.multicast++;
> -					return true;
> +					ether_frame->ether_dhost)) {
> +						adapter->rcv_multicasts++;
> +						netdev->stats.multicast++;
> +						return true;
>  				}
>  				mcaddr = mcaddr->next;
>  			}

Check patch likes the new code but the original is better for human
beings.  Sorry.

regards,
dan carpenter


  parent reply	other threads:[~2015-03-24 20:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-24 19:09 Staging: slicoss: Fix checkpatch.pl issues Niranjan Dighe
2015-03-24 19:26 ` Joe Perches
2015-03-24 20:14 ` Dan Carpenter [this message]
2015-03-24 20:27   ` Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150324201429.GV10964@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=charrer@alacritech.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=liodot@gmail.com \
    --cc=niranjan.dighe@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox