From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752860AbbCXUOX (ORCPT ); Tue, 24 Mar 2015 16:14:23 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:29650 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751713AbbCXUOV (ORCPT ); Tue, 24 Mar 2015 16:14:21 -0400 Date: Tue, 24 Mar 2015 23:14:29 +0300 From: Dan Carpenter To: Niranjan Dighe Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, charrer@alacritech.com, liodot@gmail.com, linux-kernel@vger.kernel.org Subject: Re: Staging: slicoss: Fix checkpatch.pl issues Message-ID: <20150324201429.GV10964@mwanda> References: <1427224146-7926-1-git-send-email-niranjan.dighe@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1427224146-7926-1-git-send-email-niranjan.dighe@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 25, 2015 at 12:39:06AM +0530, Niranjan Dighe wrote: > The following files had coding style issues that I tried to address. > It was mostly about lines spanning more than 80 characters. > > Signed-off-by: Niranjan Dighe > > diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c > index 3104cb0..2161bdb 100644 > --- a/drivers/staging/slicoss/slicoss.c > +++ b/drivers/staging/slicoss/slicoss.c > @@ -98,7 +98,8 @@ > #include "slic.h" > > static uint slic_first_init = 1; > -static char *slic_banner = "Alacritech SLIC Technology(tm) Server and Storage Accelerator (Non-Accelerated)"; > +static char *slic_banner = "Alacritech SLIC Technology(tm) Server " > + "and Storage Accelerator (Non-Accelerated)"; Just leave it. The original is better for grepping. > > static char *slic_proc_version = "2.0.351 2006/07/14 12:26:00"; > > @@ -755,10 +756,10 @@ static bool slic_mac_filter(struct adapter *adapter, > > while (mcaddr) { > if (ether_addr_equal(mcaddr->address, > - ether_frame->ether_dhost)) { > - adapter->rcv_multicasts++; > - netdev->stats.multicast++; > - return true; > + ether_frame->ether_dhost)) { > + adapter->rcv_multicasts++; > + netdev->stats.multicast++; > + return true; > } > mcaddr = mcaddr->next; > } Check patch likes the new code but the original is better for human beings. Sorry. regards, dan carpenter