public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ingo Molnar <mingo@kernel.org>
Cc: David Ahern <david.ahern@oracle.com>,
	linux-kernel@vger.kernel.org,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
	Stephane Eranian <eranian@google.com>,
	Adrian Hunter <adrian.hunter@intel.com>
Subject: Re: [PATCH] perf record: Allow poll timeout to be specified
Date: Tue, 24 Mar 2015 18:21:20 -0300	[thread overview]
Message-ID: <20150324212120.GA12599@kernel.org> (raw)
In-Reply-To: <20150324161210.GA8661@gmail.com>

Em Tue, Mar 24, 2015 at 05:12:11PM +0100, Ingo Molnar escreveu:
> * David Ahern <david.ahern@oracle.com> wrote:
> > Record currently wakes up based on watermarks to read events from 
> > the mmaps and write them out to the file. The result is a file that 
> > can have large blocks of events per mmap before a finished round 
> > event is added to the stream.  This in turn affects the quantity of 
> > events that have to be passed through the ordered events queue 
> > before results can be displayed to the user. For commands like 
> > perf-script this can lead to long unnecessarily long delays before a 
> > user gets output. Large systems (e.g, 1024 cpus) further compound 
> > this effect. I have seen instances where I have to wait 45 minutes 
> > for perf-script to process a 5GB file before any events are shown.
> > 
> > This patch adds an option to perf-record to allow a user to specify 
> > the poll timeout in msec. For example using 100 msec timeouts 
> > similar to perf-top means the mmaps are traversed much more 
> > frequently leading to a smoother analysis side.
> 
> Please tune the default value (perhaps influenced by N_PROC?) so that 
> users will get sane behavior without having to specify this option!

Isn't this a followup patch? I.e. changing the default from infinity to
some sane value?

Applying it now.

- Arnaldo

  parent reply	other threads:[~2015-03-24 21:22 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-24 16:09 [PATCH] perf record: Allow poll timeout to be specified David Ahern
2015-03-24 16:12 ` Ingo Molnar
2015-03-24 16:18   ` David Ahern
2015-03-24 21:21   ` Arnaldo Carvalho de Melo [this message]
2015-03-25  9:11     ` Ingo Molnar
2015-03-25 12:14       ` Arnaldo Carvalho de Melo
2015-03-25 14:41         ` David Ahern
2015-03-25 18:20           ` Ingo Molnar
2015-03-25 12:38 ` Jiri Olsa
2015-03-25 14:37   ` David Ahern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150324212120.GA12599@kernel.org \
    --to=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=david.ahern@oracle.com \
    --cc=eranian@google.com \
    --cc=fweisbec@gmail.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox