The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Alistair Strachan <alistair.strachan@imgtec.com>
Cc: linux-kernel@vger.kernel.org,
	Maarten Lankhorst <maarten.lankhorst@canonical.com>,
	Colin Cross <ccross@google.com>
Subject: Re: [PATCH] sync: Fix memory corruption in sync_timeline_signal().
Date: Tue, 24 Mar 2015 22:46:23 +0100	[thread overview]
Message-ID: <20150324214623.GA19829@kroah.com> (raw)
In-Reply-To: <1427230504-8279-1-git-send-email-alistair.strachan@imgtec.com>

On Tue, Mar 24, 2015 at 01:55:04PM -0700, Alistair Strachan wrote:
> The android_fence_release() function checks for active sync points
> by calling list_empty() on the list head embedded on the sync
> point. However, it is only valid to use list_empty() on nodes that
> have been initialized with INIT_LIST_HEAD() or list_del_init().
> 
> Because the list entry has likely been removed from the active list
> by sync_timeline_signal(), there is a good chance that this
> WARN_ON_ONCE() will be hit due to dangling pointers pointing at
> freed memory (even though the sync drivers did nothing wrong)
> and memory corruption will ensue as the list entry is removed for
> a second time, corrupting the active list.
> 
> This problem can be reproduced quite easily with CONFIG_DEBUG_LIST=y
> and fences with more than one sync point.
> 
> Change-Id: Ie2a6bc1480bbcfdc14f9b385fca5a2b833effc05

This line doesn't belong in a kernel changelog, can you please remove
and resend?

thanks,

greg k-h

  reply	other threads:[~2015-03-24 21:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-24 20:55 [PATCH] sync: Fix memory corruption in sync_timeline_signal() Alistair Strachan
2015-03-24 21:46 ` Greg Kroah-Hartman [this message]
2015-03-24 21:51 ` Alistair Strachan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150324214623.GA19829@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=alistair.strachan@imgtec.com \
    --cc=ccross@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@canonical.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox