From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: driverdevel <devel@driverdev.osuosl.org>,
"Noralf Trønnes" <noralf@tronnes.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] staging: fbtft: Do not use binary constants
Date: Tue, 24 Mar 2015 23:07:41 +0100 [thread overview]
Message-ID: <20150324220741.GA5994@kroah.com> (raw)
In-Reply-To: <CAMuHMdUC8MAs2myYX8SJcczg7qQJNr2z3dqTMspvYzEe8_LB3w@mail.gmail.com>
On Fri, Mar 20, 2015 at 04:19:36PM +0100, Geert Uytterhoeven wrote:
> Hi Greg,
>
> On Fri, Mar 20, 2015 at 1:54 PM, Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> > On Tue, Mar 10, 2015 at 10:34:43PM +0100, Geert Uytterhoeven wrote:
> >> Gcc < 4.3 doesn't understand binary constants (0b*):
> >>
> >> drivers/staging/fbtft/fbtft-sysfs.c:156:19: error: invalid suffix "b111" on integer constant
> >> drivers/staging/fbtft/fb_hx8340bn.c:159:3: error: invalid suffix "b1111" on integer constant
> >> drivers/staging/fbtft/fb_hx8340bn.c:159:11: error: invalid suffix "b1111" on integer constant
> >> drivers/staging/fbtft/fb_hx8340bn.c:159:19: error: invalid suffix "b11111" on integer constant
> >> drivers/staging/fbtft/fb_hx8340bn.c:159:28: error: invalid suffix "b1111" on integer constant
> >> drivers/staging/fbtft/fb_hx8340bn.c:159:36: error: invalid suffix "b1111" on integer constant
> >> drivers/staging/fbtft/fb_hx8340bn.c:159:44: error: invalid suffix "b1111" on integer constant
> >> drivers/staging/fbtft/fb_hx8340bn.c:159:52: error: invalid suffix "b11111" on integer constant
> >> drivers/staging/fbtft/fb_hx8340bn.c:160:3: error: invalid suffix "b111" on integer constant
> >> ...
> >>
> >> Hence use hexadecimal constants (0x*) instead.
> >>
> >> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> >> ---
> >> This is against v4.0-rc3. In next-20150310 there are two whitespace
> >> differences.
> >
> > Can you make it against -next? I can't get this to apply as-is, sorry.
>
> Sure, will do. I was wondering if you wanted to sent this fix to Linus for v4.0,
> as the build is broken for gcc < 4.3, and keep the changes in -next for v4.1.
Nah, it's just staging code, it's ok to be broken on old compilers :)
thanks,
greg k-h
next prev parent reply other threads:[~2015-03-24 22:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-10 21:34 [PATCH] staging: fbtft: Do not use binary constants Geert Uytterhoeven
2015-03-10 21:50 ` Joe Perches
2015-03-10 21:53 ` Geert Uytterhoeven
2015-03-20 12:54 ` Greg Kroah-Hartman
2015-03-20 15:19 ` Geert Uytterhoeven
2015-03-24 22:07 ` Greg Kroah-Hartman [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-03-20 15:21 Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150324220741.GA5994@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=noralf@tronnes.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox