From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752730AbbCXWHp (ORCPT ); Tue, 24 Mar 2015 18:07:45 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:37934 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752235AbbCXWHo (ORCPT ); Tue, 24 Mar 2015 18:07:44 -0400 Date: Tue, 24 Mar 2015 23:07:41 +0100 From: Greg Kroah-Hartman To: Geert Uytterhoeven Cc: driverdevel , Noralf =?iso-8859-1?Q?Tr=F8nnes?= , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] staging: fbtft: Do not use binary constants Message-ID: <20150324220741.GA5994@kroah.com> References: <1426023283-27561-1-git-send-email-geert@linux-m68k.org> <20150320125442.GA30615@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 20, 2015 at 04:19:36PM +0100, Geert Uytterhoeven wrote: > Hi Greg, > > On Fri, Mar 20, 2015 at 1:54 PM, Greg Kroah-Hartman > wrote: > > On Tue, Mar 10, 2015 at 10:34:43PM +0100, Geert Uytterhoeven wrote: > >> Gcc < 4.3 doesn't understand binary constants (0b*): > >> > >> drivers/staging/fbtft/fbtft-sysfs.c:156:19: error: invalid suffix "b111" on integer constant > >> drivers/staging/fbtft/fb_hx8340bn.c:159:3: error: invalid suffix "b1111" on integer constant > >> drivers/staging/fbtft/fb_hx8340bn.c:159:11: error: invalid suffix "b1111" on integer constant > >> drivers/staging/fbtft/fb_hx8340bn.c:159:19: error: invalid suffix "b11111" on integer constant > >> drivers/staging/fbtft/fb_hx8340bn.c:159:28: error: invalid suffix "b1111" on integer constant > >> drivers/staging/fbtft/fb_hx8340bn.c:159:36: error: invalid suffix "b1111" on integer constant > >> drivers/staging/fbtft/fb_hx8340bn.c:159:44: error: invalid suffix "b1111" on integer constant > >> drivers/staging/fbtft/fb_hx8340bn.c:159:52: error: invalid suffix "b11111" on integer constant > >> drivers/staging/fbtft/fb_hx8340bn.c:160:3: error: invalid suffix "b111" on integer constant > >> ... > >> > >> Hence use hexadecimal constants (0x*) instead. > >> > >> Signed-off-by: Geert Uytterhoeven > >> --- > >> This is against v4.0-rc3. In next-20150310 there are two whitespace > >> differences. > > > > Can you make it against -next? I can't get this to apply as-is, sorry. > > Sure, will do. I was wondering if you wanted to sent this fix to Linus for v4.0, > as the build is broken for gcc < 4.3, and keep the changes in -next for v4.1. Nah, it's just staging code, it's ok to be broken on old compilers :) thanks, greg k-h