From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: David Ahern <david.ahern@oracle.com>
Cc: linux-kernel@vger.kernel.org, Jiri Olsa <jolsa@kernel.org>,
Namhyung Kim <namhyung@kernel.org>
Subject: Re: [PATCH] perf tool: Add event name to error message for filters
Date: Tue, 24 Mar 2015 19:23:18 -0300 [thread overview]
Message-ID: <20150324222318.GD12599@kernel.org> (raw)
In-Reply-To: <5511DE84.2060707@oracle.com>
Em Tue, Mar 24, 2015 at 04:00:36PM -0600, David Ahern escreveu:
> On 3/24/15 3:57 PM, Arnaldo Carvalho de Melo wrote:
> >With the patch below, that leaves printing something, using whatever UI, to the
> >tool, acceptable?
>
> I keep forgetting about the python bindings.
Oh, its not just about the python bindings, but kinda layering
violation, i.e. we should leave the error reporting to the actual tool,
that may be using GTK, Qt, some custom made TUI, whatever UI.
The python bindings, were not a problem somehow, at least 'perf test
python' hasn't failed when I tried.
> Your patch serves the purpose. Thanks, Arnaldo.
Thanks,
Applying with your Acked-by and Based-on-a-patch-by.
- Arnaldo
next prev parent reply other threads:[~2015-03-24 22:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-24 16:10 [PATCH] perf tool: Add event name to error message for filters David Ahern
2015-03-24 21:29 ` Arnaldo Carvalho de Melo
2015-03-24 21:57 ` Arnaldo Carvalho de Melo
2015-03-24 22:00 ` David Ahern
2015-03-24 22:23 ` Arnaldo Carvalho de Melo [this message]
2015-03-25 11:19 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150324222318.GD12599@kernel.org \
--to=acme@kernel.org \
--cc=david.ahern@oracle.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox