From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752667AbbCXWXV (ORCPT ); Tue, 24 Mar 2015 18:23:21 -0400 Received: from mail.kernel.org ([198.145.29.136]:56638 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752604AbbCXWXS (ORCPT ); Tue, 24 Mar 2015 18:23:18 -0400 Date: Tue, 24 Mar 2015 19:23:18 -0300 From: Arnaldo Carvalho de Melo To: David Ahern Cc: linux-kernel@vger.kernel.org, Jiri Olsa , Namhyung Kim Subject: Re: [PATCH] perf tool: Add event name to error message for filters Message-ID: <20150324222318.GD12599@kernel.org> References: <1427213417-127183-1-git-send-email-david.ahern@oracle.com> <20150324212956.GB12599@kernel.org> <20150324215737.GC12599@kernel.org> <5511DE84.2060707@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5511DE84.2060707@oracle.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Tue, Mar 24, 2015 at 04:00:36PM -0600, David Ahern escreveu: > On 3/24/15 3:57 PM, Arnaldo Carvalho de Melo wrote: > >With the patch below, that leaves printing something, using whatever UI, to the > >tool, acceptable? > > I keep forgetting about the python bindings. Oh, its not just about the python bindings, but kinda layering violation, i.e. we should leave the error reporting to the actual tool, that may be using GTK, Qt, some custom made TUI, whatever UI. The python bindings, were not a problem somehow, at least 'perf test python' hasn't failed when I tried. > Your patch serves the purpose. Thanks, Arnaldo. Thanks, Applying with your Acked-by and Based-on-a-patch-by. - Arnaldo