From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753079AbbCYCmO (ORCPT ); Tue, 24 Mar 2015 22:42:14 -0400 Received: from ipmail06.adl2.internode.on.net ([150.101.137.129]:39666 "EHLO ipmail06.adl2.internode.on.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752363AbbCYCmK (ORCPT ); Tue, 24 Mar 2015 22:42:10 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A2BVCABqHxJVPAYQLHlcgwaBLIY/rGUBAQEBAQEGmQwCAgEBAoFOTQEBAQEBAQYBAQEBODuEFQEFJxMcIxAIAxgJJQ8FJQMHGhOILslvAQEIAgEfGIV1hRSEdgeDF4EWAQSOQot8lC2CJByBZCoxgkMBAQE Date: Wed, 25 Mar 2015 13:41:54 +1100 From: Dave Chinner To: Jens Axboe Cc: axboe@kernel.dk, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, ming.l@ssi.samsung.com Subject: Re: [PATCH 6/6] xfs: add support for buffered writeback stream ID Message-ID: <20150325024154.GE31342@dastard> References: <1427210823-5283-1-git-send-email-axboe@fb.com> <1427210823-5283-7-git-send-email-axboe@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1427210823-5283-7-git-send-email-axboe@fb.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 24, 2015 at 09:27:03AM -0600, Jens Axboe wrote: > Signed-off-by: Jens Axboe > --- > fs/xfs/xfs_aops.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/fs/xfs/xfs_aops.c b/fs/xfs/xfs_aops.c > index 3a9b7a1b8704..2b00a57732e3 100644 > --- a/fs/xfs/xfs_aops.c > +++ b/fs/xfs/xfs_aops.c > @@ -377,6 +377,7 @@ xfs_submit_ioend_bio( > atomic_inc(&ioend->io_remaining); > bio->bi_private = ioend; > bio->bi_end_io = xfs_end_bio; > + bio_set_streamid(bio, wbc->streamid); > submit_bio(wbc->sync_mode == WB_SYNC_ALL ? WRITE_SYNC : WRITE, bio); Like I said, this is wrong. + bio_set_streamid(bio, ioend->io_inode->i_streamid); is actually what it should be. Cheers, Dave. -- Dave Chinner david@fromorbit.com