From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752789AbbCYDTu (ORCPT ); Tue, 24 Mar 2015 23:19:50 -0400 Received: from mga02.intel.com ([134.134.136.20]:13413 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752102AbbCYDTs (ORCPT ); Tue, 24 Mar 2015 23:19:48 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,462,1422950400"; d="scan'208";a="685183120" Date: Tue, 24 Mar 2015 20:19:46 -0700 From: Andi Kleen To: Len Brown Cc: Andi Kleen , "linux-kernel@vger.kernel.org" , Linux PM list Subject: Re: [PATCH 1/2] Support PCU power metrics in turbostat Message-ID: <20150325031946.GC15335@tassilo.jf.intel.com> References: <1415920790-23163-1-git-send-email-andi@firstfloor.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 24, 2015 at 05:20:13PM -0400, Len Brown wrote: > > > On Thu, Nov 13, 2014 at 6:19 PM, Andi Kleen wrote: > > From: Andi Kleen > > > > Add support for reading PCU power metrics on Sandy Bridge / Ivy Bridge EP > > and Haswell Server in turbostat. This is done using the perf ABI, > > using the perf uncore driver. This requires the kernel to > > have uncore perf driver support. > > What happens if kernel doesn't include that support? The data is not displayed. > > The user has to specify the event group using a new -x option. All > > more sensible option characters were already taken. When -x is > > not specified no behavior changes. > > I'm concerned that turbostat cmdline is getting too complicated, > and this makes that more the case. Modern computers are complicated. No way around it. > > However this currently runs into a problem with the uncore > > driver that only makes us able to monitor a single band. > > Disabled until this is fixed. BTW this is fixed. Will update. > > Custom user metrics would be also possible. > > > > The event resolution code is derived from the jevents library > > (parts of pmu-tools, http://github.com/andikleen/pmu-tools) > > and is BSD licensed. > > can we put BSD licensed code into utilities that are in the linux > kernel git tree? I think so. There are already some. -Andi